Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider disabling default features on image crate #225

Open
nazar-pc opened this issue Aug 10, 2024 · 1 comment
Open

Consider disabling default features on image crate #225

nazar-pc opened this issue Aug 10, 2024 · 1 comment
Milestone

Comments

@nazar-pc
Copy link

nazar-pc commented Aug 10, 2024

When images feature is enabled and image dependency is brought in, it pulls in a bunch of other dependencies to support various image formats, though according to quick search they are not used in this crate, so using default-features = false would allow to remove a lot of unnecessary indirect dependencies.

UPD: Yes, there is Image::open(), but for those who decode images themselves it should not be required to pull all of the dependencies and if that is in fact needed, additional feature can be used just for that.

@hoodie
Copy link
Owner

hoodie commented Aug 11, 2024

That is a great point. Thanks.

@hoodie hoodie added this to the v5.0.0 milestone Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants