072.md

IceBear

medium

Use safeTransferFrom instead of transferFrom for ERC721 transfers

Summary

Use safeTransferFrom to prevent loss.

Vulnerability Detail

Transferfrom doesn't ensure that the receiver is capable of receiving the token, which can lead to permanently loosing the token. similar findings:

• https://code4rena.com/reports/2022-05-cally#m-09-use-safetransferfrom-instead-of-transferfrom-for-erc721-transfers
• https://code4rena.com/reports/2021-06-pooltogether/#m-07-using-transferfrom-on-erc721-tokens

Impact

According to the openzeppelin-contracts usage of {safeTransferFrom} prevents loss.

Code Snippet

https://github.com/sherlock-audit/2023-03-teller/blob/main/teller-protocol-v2/packages/contracts/contracts/CollateralManager.sol#L343

Tool used

Manual Review

Recommendation

Consider changing transferFrom to safeTransferFrom at L343.