fix: dockerfile copy vs add #208
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related Issue
This PR fixes a release time issue with #206,
https://github.com/hotosm/OpenAerialMap/actions/runs/16059563354/job/45322169917
Describe this PR
This PR changes the Dockerfile to use
COPY
instead ofADD
(as was used in theuv
docs) sinceADD
is possibly less secure as it can interact with remote files.Screenshots
N/A
Alternative Approaches Considered
N/A
Review Guide
Should we add Checkov to the CI/CD and perhaps also to the pre-commit setup? I checked that this passed,
based on how the image publishing workflow uses checkov.
I also added Checkov to the pre-commit hook setup using the default "skip CVE" arguments.
edit - I reverted this because
pre-commit.ci
refused to clone the Checkov repo as it was too largeChecklist before requesting a review
[optional] What gif best describes this PR or how it makes you feel?
🚀