Feature Request: Suppressing server-side logs in configuration

[milkeclair]

Hi, I am trying to use this gem in Rails 8!

I find this gem very useful, but when using it, I frequently see log messages related to Hotwire Spark.

To work around this, I created the following initializer.
However, I was wondering if there are any plans to support server-side log suppression in the gem’s configuration
(or if it can be done in the first place).
If such a setting already exists, please let me know.

Thanks for making a useful gem!

#config/initializers/hotwire_spark.rb

return if !defined?(Hotwire) || !defined?(Hotwire::Spark) || !Hotwire::Spark.enabled?

Hotwire::Spark.cable_server.config.logger = Logger.new(nil)
Hotwire::Spark.cable_server.config.cable = { "adapter" => "async" }

class SilentSpark < ActionController::LogSubscriber
  def start_processing(event)
    return if event.payload[:params][:hotwire_spark]
    super(event)
  end

  def process_action(event)
    return if event.payload[:params][:hotwire_spark]
    super(event)
  end
end

ActionController::LogSubscriber.detach_from :action_controller
SilentSpark.attach_to :action_controller

[jorgemanrubia]

Thanks @milkeclair. I think this is a great idea. I'd be happy to a accept a PR here adding a new boolean option server_logging to turn logs on/off (default to "on"). Then, we would also rename the existing option logging to client_logging to clarify the difference.

[milkeclair]

I have been trying to figure out how to implement this feature for a while, but have not been able to come up with a way to do it without side effects.
main...milkeclair:server-logging
works with test/dummy, but there are currently two problems.

The first is that the middleware forces the user to append ActionView::LogSubscriber even if the original LogSubscriber is used.

Second, I don't know how to test this.

log_stack = []
mock_logger = Logger.new(StringIO.new)
mock_logger.formatter = proc { |_severity, _datetime, _progname, message| log_stack << message }
Rails.logger = mock_logger

visit “#{root_path}?hotwire_spark=1”

assert_no_match(/Started GET “\/\?hotwire_spark=1”/, log_stack.join)

I can't figure out how to change the settings in application.rb during the test, so this test doesn't work properly.

If anyone has a better way of doing this I would be grateful.