-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preview Pane is not cleared on Tmux but fine on foot #241
Comments
Hmm. I suspect this is a tmux issue. Can you try this:
Inside plain foot, and inside tmux running under foot. Here it produces a small image overlaid on a big image in foot, but only the small image in tmux. Foot's behavior is the correct one. However, this is the opposite of what you're seeing in fzf-preview, so maybe it's caused by something else. |
Let's try to rule out the easy stuff - which Chafa version are you running ( Older versions of tmux require the use of passthrough, and Chafa from the master branch is better at detecting when it'll work without passthrough. This gives better results. tmux with passthrough tends to dispose of images immediately like you're seeing in the test above (left hand side). If you're using a 1.14.x release of Chafa, do you think you'd be able to test with the master branch instead? |
Yes, you are right.
chafa --version
Chafa version 1.14.5
Loaders: GIF JPEG PNG QOI TIFF WebP XWD
Features: mmx sse4.1 popcnt avx2
Applying: mmx sse4.1 popcnt avx2
Copyright (C) 2018-2024 Hans Petter Jansson et al.
Incl. libnsgif copyright (C) 2004 Richard Wilson, copyright (C) 2008 Sean Fox
Incl. LodePNG copyright (C) 2005-2018 Lode Vandevenne
Incl. QOI decoder copyright (C) 2021 Dominic Szablewski
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
I successfully built Below is the package override I used: pkgs.chafa.overrideAttrs (oldAttrs: rec {
version = "05e7609";
pname = "chafa";
src = pkgs.fetchFromGitHub {
owner = "hpjansson";
repo = "chafa";
rev = version;
sha256 = "sha256-bU/Wp3e0/x+4cYolKBrilrRzFL93hJW8l7xJguiRpIs=";
};
});
Chafa version 1.15.0
Loaders: GIF JPEG PNG QOI TIFF WebP XWD
Features: mmx sse4.1 popcnt avx2
Applying: mmx sse4.1 popcnt avx2
Copyright (C) 2018-2024 Hans Petter Jansson et al.
Incl. libnsgif copyright (C) 2004 Richard Wilson, copyright (C) 2008 Sean Fox
Incl. LodePNG copyright (C) 2005-2018 Lode Vandevenne
Incl. QOI decoder copyright (C) 2021 Dominic Szablewski
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
The behavior persists in the master branch as well. |
Thanks, that's useful to know. The next thing to try is to run it in as basic an environment as possible -- e.g. bog standard bash shell and no customizations. A simple way to do it would be to create a new user and try it there. Edit: You might get different results in a different terminal with sixel or kitty capabilities. I'd check with |
Good, so we know foot and mlterm produce the same results. The kitty alnum spew sounds like fzf could be interfering with kitty images. The tmux As for the failure-to-clear-sixels glitch, I can't think of anything else to test at the moment - I'll have to find some time to investigate the foot/tmux/fzf/fzf-preview chain locally. Probably next week. |
NOTE: Maybe it is not related to
chafa
at all but puttint the behaviour issue here if any implementation can fix thi.So i just created a small script to preview images and text based on filetype in fzf-preview.
chafa
works fine on tmux for me,chafa -f sixels <image.png>
shows the image in the terminal and tmux window.*The glitch does not happen on foot terminal but only occurs in the tmux window
For reference preview script
The text was updated successfully, but these errors were encountered: