Skip to content

Commit 79d00c3

Browse files
authored
[skip ci] scripts: handle float64 and totally same type definitions in kafka_gen.py (#1833)
1 parent d77cf56 commit 79d00c3

File tree

1 file changed

+10
-3
lines changed

1 file changed

+10
-3
lines changed

script/kafka_gen.py

+10-3
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@
5454
"int32": "{{-# UNPACK #-}} !Int32",
5555
"int16": "{{-# UNPACK #-}} !Int16",
5656
"int64": "{{-# UNPACK #-}} !Int64",
57+
"float64": "{{-# UNPACK #-}} !Double",
5758
"string": "!Text",
5859
"bool": "Bool",
5960
"bytes": "!ByteString",
@@ -131,6 +132,9 @@ def get_field_default(field_type, default=None):
131132
"DescribeGroups": (0, 1),
132133
"FindCoordinator": (0, 1),
133134
"CreatePartitions": (0, 1),
135+
"CreateAcls": (0, 1),
136+
"DeleteAcls": (0, 1),
137+
"DescribeAcls": (0, 1)
134138
}
135139

136140
# -----------------------------------------------------------------------------
@@ -306,10 +310,11 @@ def format(self):
306310

307311
def append_hs_datas(datas: List[HsData], data: HsData):
308312
same_found = False
313+
totally_same_found = False
309314
for data_ in datas:
310315
if data.name == data_.name:
311-
# The same data_name should not has the same version
312-
assert data.version != data_.version
316+
if (data.version == data_.version and data.fields == data_.fields):
317+
totally_same_found = True
313318

314319
# Use the first same type is OK
315320
if (
@@ -322,8 +327,10 @@ def append_hs_datas(datas: List[HsData], data: HsData):
322327
f"{data.name}V{data_.version}"
323328
)
324329
data.fields = data_.version
330+
325331
same_found = True
326-
datas.append(data)
332+
if (not totally_same_found):
333+
datas.append(data)
327334

328335

329336
# -----------------------------------------------------------------------------

0 commit comments

Comments
 (0)