Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull requests aren'accepted #908

Open
Hermholtz opened this issue Dec 17, 2024 · 7 comments
Open

Pull requests aren'accepted #908

Hermholtz opened this issue Dec 17, 2024 · 7 comments

Comments

@Hermholtz
Copy link

I've just received a notification that my PR #872 is already more than a year old.
Pull requests are ready-made features or bugfixes that you can easily integrate with the product.
Why aren't they reviewed, accepted, rejected or closed in any other meaningful way?

@Neboer
Copy link

Neboer commented Dec 31, 2024

This project is nearly dead. Please dont care about it anymore...

@Hermholtz
Copy link
Author

That is very unfortunate, as it is a very useful piece of software.

@eytienne
Copy link

eytienne commented Jan 2, 2025

@Neboer I saw a PR two months ago, how do you motivate your comment? any replacement in sight?

@Neboer
Copy link

Neboer commented Jan 2, 2025

Although the project's code is updating, the last release is still at Jun 1, 2022. You download it from npm registery the same version just as it was two years ago.

@eytienne
Copy link

eytienne commented Jan 2, 2025

@Neboer right, I had to clone the repo and use yarn link to benefit from the recent --base-dir feature...

@KernelDeimos
Copy link
Contributor

Hi all, I took on maintenance a few months ago to help out with this, then got very busy for a couple months unfortunately. While I was doing this, I noticed that maintenance would be a lot easier if we had more technical analysis of contributions.

If any of you want to collaborate - Discord, Matrix, etc; I would lean toward Discord primarily because it would attract newer developers - we could then standardize these processes and bring some life back into this repo.

Steps look like this:

  1. Understand the change being made and why it's being made
  2. Look at existing code and note "how would you do it?" (this ensures an opportunity to bring original ideas the contributor may not have thought of)
  3. Compare the solution, make sure it makes sense, etc
  4. Meticulously review code for potential security issues
  5. Meticulously review code for potential regressions

@Hermholtz
Copy link
Author

Hi, it's great that it moves. While I can't engage fully at the moment, I can offer my PR #872
which was tested, and it doesn't contain any security issue. It's ready for merging and will fix a long-standing annoying issue of server not being able to proxy WebSocket connections.
Hope this great piece of software will receive adequate attention.
All the best!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants