Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Determine whether serialization-only tests can cover behavior of significant fractional digits #99

Open
apasel422 opened this issue Feb 4, 2025 · 1 comment · May be fixed by #100
Open

Determine whether serialization-only tests can cover behavior of significant fractional digits #99

apasel422 opened this issue Feb 4, 2025 · 1 comment · May be fixed by #100

Comments

@apasel422
Copy link
Contributor

To help add coverage that would prevent issues like undef1nd/sfv#115.

Unfortunately, I'm not sure that it's possible given that these tests use JSON numbers (rather than strings) to represent decimal values, because there is no guarantee that a JSON number 123.10 will retain the trailing 0 on parsing.
@apasel422
Copy link
Contributor Author

Actually, it appears that there isn't even regular test coverage of the canonical form here.

@apasel422 apasel422 linked a pull request Feb 4, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add tests covering canonicalization of insignificant decimal digits apasel422/structured-field-tests
1 participant
@apasel422