Some colors don't have enough contrast

[crt0r]

First of all, thank you for developing such a good theme!

I write a lot of documentation in Markdown for my work and sometimes have a hard time reading the text in a preview or an editor. So far, the issues are with blockquotes and some code blocks.

1. Some parts of the code block are nearly the same color as the background, so they are barely readable.
   
   

2. The blockquote at the bottom of the screenshot is very light.
   

[huacat1017]

First of all, Thank you for reporting these!
the code block issue seems like I don't color these. But I don't know the elements now.
the second issue: It's the light green color in my color palette, maybe make it (blockquote texts) deeper or a new color to fix it.
I have no time working on this these days. I'll fix these on Nov 5 if there is no urgent homework.

[huacat1017]

Sorry for late replying. I’m not sure when I will be free to fix. My time management has been a mess. I’m sorry to delay and delay this. Hope to use my time better.

[crt0r]

Sorry for late replying. I’m not sure when I will be free to fix. My time management has been a mess. I’m sorry to delay and delay this. Hope to use my time better.

Nothing serious. I have the same issues with my time due to college and day job. Especially because it's the end of the year and it's the period of final deadlines--for this year. Just focus on what's important for you first right now, Open Source comes next. 😸

[huacat1017]

I opened a new issue and mentioned this to VScode team. The code block problem is not as easy as I thought.
If you want to edit it yourself, go to "C:\Users%USERNAME%\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\markdown-language-features\media\highlight.css" (Windows) to change the .hljs-subst class color by adding these lines on the file: (In my opinion, the color can fit few of light themes.)

.vscode-light .hljs-subst,
.vscode-light .hljs-function,
.vscode-light .hljs-title,
.vscode-light .hljs-params,
.vscode-light .hljs-formula {
	color: #909090; /*Change the color to what you like*/
}

They use highlight.js to get the Preview colored. You can check this issue. They recommended Markdown Preview VS Code Highlighting extension to make the syntax in the code blocks match active color theme because Shiki uses TextMate. (Shell script works well, but it only has two default themes for C++) Syntax in Markdown Preview might be a problem for a long time. (OR you can go to Settings -> markdown.styles add the CSS yourself but it is unconvenient)

If you don't care about the background. You can try Markdown Preview Enhanced and Markdown Preview Github Styling to avoid the text unable to read.

[crt0r]

They use highlight.js to get the Preview colored. You can check this issue. They recommended Markdown Preview VS Code Highlighting extension to make the syntax in the code blocks match active color theme because Shiki uses TextMate.

Thanks for the detailed reply! I'll try out these extensions.

[huacat1017]

I tried a darker color. Are you OK with this color?

Before (#99ca82)	After (#3d8b1c)

[crt0r]

I tried a darker color. Are you OK with this color?
Before (#99ca82) After (#3d8b1c)

Yep, it's a lot more readable.

[huacat1017]

Published 0.4.1 to fix these. Enjoy!

[crt0r]

Thanks!