Extra requirement hf_transfer
is broken for some pip versions
#3029
Labels
bug
Something isn't working
Describe the bug
There are versions of pip which the extra requirement
hf_transfer
doesn't work - thehf_transfer
package is not installed.Reproduction
Use pip version
22.0.2
and verify that the packagehf-transfer
is not installed:Newer pip versions install
hf-transfer
:Details
The release workflow uses setuptools version 58.1.0, which was released in 2021.
This version produces a wheel file in which the definition of the
hf_transfer
extra in theMETADATA
file is inconsistent:Note the difference between the two lines: one uses an underscore (
hf_transfer
), the other a hyphen (hf-transfer
).It appears that older pip versions can't handle this correctly:
The difference in the extra name in
METADATA
does not happen with newer releases ofsetuptools
:Now the extra name in the two lines is identical.
I was going to create a pull request which upgrades
setuptools
in the release workflow, but I'm noting that in the name of the extra the underscore was replaced by a hyphen:hf-transfer
instead ofhf_transfer
. Since the documentation useshf_transfer
this would be a breaking change. So, I'm leaving this here as an issue to discuss the path forwardLogs
System info
The text was updated successfully, but these errors were encountered: