Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get opentelemetry trace id from request headers instead of creating a new trace #374

Open
ptanov opened this issue Aug 8, 2024 · 2 comments · May be fixed by #425
Open

Get opentelemetry trace id from request headers instead of creating a new trace #374

ptanov opened this issue Aug 8, 2024 · 2 comments · May be fixed by #425

Comments

@ptanov
Copy link

ptanov commented Aug 8, 2024

Feature request

Currently a new trace is created per each HTTP request. It would be useful if trace is get (if available) from the request using traceparent header as defined in https://opentelemetry.io/docs/specs/otel/context/api-propagators/#propagators-distribution https://www.w3.org/TR/trace-context/

In this way you will be able to trace the request through microservice invocations.

Motivation

I want to track the request using opentelemetry starting from frontend, backend and then TEI

Your contribution

I don't have enough understanding of TEI code
@ptanov
Copy link
Author

ptanov commented Aug 15, 2024

Created similar issue for TGI here: huggingface/text-generation-inference#2376

@kozistr kozistr linked a pull request Oct 14, 2024 that will close this issue
Open
5 tasks
@ptanov
Copy link
Author

ptanov commented Oct 16, 2024

Hello,

I tested this PR and I can confirm that it works in my case - opentelemetry trace is propagated from request to TGI.

Thanks @kozistr !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Get opentelemetry trace id from request headers kozistr/text-embeddings-inference
1 participant
@ptanov