-
Notifications
You must be signed in to change notification settings - Fork 29.3k
[1/N] Use list,tuple,dict for typing #38713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
7acf790
to
2e772de
Compare
28b8d24
to
a17e7d7
Compare
Happy to have these changes. But could this be produced via a single command? |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Signed-off-by: cyy <[email protected]>
@ydshieh Thank you, these are also based on ruff and sed, focusing on these types for easier review. |
No because ruff is not strong enough to fix comments.
|
b9d7a1c
to
eb23ad1
Compare
Signed-off-by: cyy <[email protected]>
Yes, go ahead. Thank you a lot. I'm not sure what If you have a list of things to be updated before py39 reaches EOL, let's see if we can do it once (you can open an issue to describe them and we can discuss). |
@Rocketknight1 Do what you want. But commit 23aea60 is required and should be picked to fix checkers. |
@ydshieh I prefer following @Rocketknight1 's advice, he makes a big PR from some commands that is reproducible and be reviewed internally. |
What does this PR do?
Replace typing.{List,Tuple,Dict} with {list, tuple,dict}. Due to the large amount of all changes, they are split into smaller PRs.