Support sortable and non-sortable columns together

[bleakley]

An example use: https://github.com/hyparam/hyperparam.app/issues/117

One way to support this would be to pass in a column props array like

<HighTable
   columnOptions={[ { className: 'userColumn', sortable: true}, { className: 'systemColumn', sortable: false } ]}
/>

this could replace the current columnClassNames and could be expanded in the future.

[severo]

If I understand well, you should already be able to apply different styles for sortable columns using the following selector:

hightable/src/components/HighTable/HighTable.module.css

Line 51 in afef182

th[aria-sort] {

Please tell me if it's not possible. Hopefully it's possible to use CSS only for that purpose, to keep the logic as simple as possible.

[bleakley]

I don't think what I want to do is currently possible. If I have two columns, columnSortable and columnNonsortable, I can pass in different styles to those columns. I can use the styles to prevent the user from sorting columnNonsortable (using pointer-events: none;), however that will also stop me from resizing (and opening the column menu once that is implemented). If I try to do something like:

.hightable thead th {
  pointer-events: none;
  cursor: default;
}

.hightable thead th[aria-sort'] {
  pointer-events: all;
  cursor: pointer;
}

That won't work because all the columns have aria-sort because hightable doesn't really know which columns are sortable.

[bleakley]

The best I think I can do is have the onOrderByChange I pass in to hightable silently exit when the user clicks on an unsortable column. That might be preferable to what I am doing now. But there are still some areas where I think it would be beneficial for hightable to know which columns are sortable. For example the current title text assumes all columns can be sorted.

[severo]

Hmmm, I hadn't paid attention: you have sortable and non-sortable columns in the same dataframe.

It's not supported yet, and I think it's the real issue we want to support. Can you update your issue or open a new one?

[bleakley]

Sure, I updated the title and description.

[severo]

I think that a column being sortable/non-sortable is inherent to the dataframe (a dataframe CAN or CANNOT sort along a column), so... I propose to add this information to the dataframe V2 proposal (#203 / #208).

Passing a column custom class is different and works well as an option.