lint v8

hyperdxio · Feb 11, 2025 · e8fc4a9 · e8fc4a9
1 parent e049d2e
commit e8fc4a9
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 8 deletions.
diff --git a/packages/app/src/TimelineChart.tsx b/packages/app/src/TimelineChart.tsx
@@ -334,6 +334,7 @@ type Row = {
   label: React.ReactNode;
   events: TimelineEventT[];
   style?: any;
+  type?: string;
   className?: string;
 };
 

diff --git a/packages/app/src/components/DBTracePanel.tsx b/packages/app/src/components/DBTracePanel.tsx
@@ -206,7 +206,7 @@ export default function DBTracePanel({
           </Text>
           <RowDataPanel
             source={
-              traceRowWhere?.type === SourceKind.Log
+              traceRowWhere?.type === SourceKind.Log && parentSourceData
                 ? parentSourceData
                 : traceSourceData
             }

diff --git a/packages/app/src/components/DBTraceWaterfallChart.tsx b/packages/app/src/components/DBTraceWaterfallChart.tsx
@@ -1,6 +1,10 @@
 import { useCallback, useMemo, useState } from 'react';
 import TimestampNano from 'timestamp-nano';
-import { SourceKind, TSource } from '@hyperdx/common-utils/dist/types';
+import {
+  ChartConfigWithDateRange,
+  SourceKind,
+  TSource,
+} from '@hyperdx/common-utils/dist/types';
 import { Text } from '@mantine/core';
 
 import useOffsetPaginatedQuery from '@/hooks/useOffsetPaginatedQuery';
@@ -57,7 +61,6 @@ function getTableBody(tableModel: TSource) {
 }
 
 function getFetchConfig(source: TSource, traceId: string) {
-  if (!source) return { config: null, alias: {}, type: null };
   const alias = {
     Body: getTableBody(source),
     Timestamp: getDisplayedTimestampValueExpression(source),
@@ -169,19 +172,21 @@ function useFetchingData({
       valueExpression: string;
       alias: string;
     }[];
-    from: string;
+    from: {
+      databaseName: string;
+      tableName: string;
+    };
     timestampValueExpression: string;
     where: string;
     limit: {
       limit: number;
     };
     connection: string;
-  } | null;
+  };
   dateRangeStartInclusive: boolean;
   dateRange: [Date, Date];
 }) {
-  const query = useMemo(() => {
-    if (!config) return null;
+  const query: ChartConfigWithDateRange = useMemo(() => {
     return {
       ...config,
       dateRange,
@@ -550,7 +555,7 @@ export function DBTraceWaterfallChartContainer({
             // onTimeClick(ts + startedAt);
           }}
           onEventClick={event => {
-            onClick?.({ id: event.id, type: event.type });
+            onClick?.({ id: event.id, type: event.type ?? '' });
           }}
           cursors={[]}
           rows={timelineRows}

diff --git a/packages/common-utils/src/types.ts b/packages/common-utils/src/types.ts
@@ -73,6 +73,7 @@ export const SelectListSchema = z.array(DerivedColumnSchema).or(z.string());
 export const SortSpecificationSchema = z.intersection(
   RootValueExpressionSchema,
   z.object({
+    valueExpression: z.string().optional(),
     ordering: z.enum(['ASC', 'DESC']),
   }),
 );