Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Akamai example is broken on negotiated ALPN #808

Open
GlenDC opened this issue Nov 4, 2024 · 0 comments
Open

Akamai example is broken on negotiated ALPN #808

GlenDC opened this issue Nov 4, 2024 · 0 comments

Comments

@GlenDC
Copy link
Contributor

GlenDC commented Nov 4, 2024

The akamai example (https://github.com/hyperium/h2/blob/master/examples/akamai.rs) is broken on the assert_eq!(Some(ALPN_H2.as_bytes()), negotiated_protocol) statement.

Can easily be "fixed" by moving it to example.com instead, but given that a lot of tests make use of akamai I imagine you have good reasons for wanting to use their server.

Seems the ALPN is not returned in the location supported by rustls. It does contain ALPN data in 1.3 encryption, but didn't dive deep enough to see if that indeed contains h2 confirmation or not. Forcing it to tls 1.2 also doesn't change anything. example.com server does return the h2 ALPN back as selection.

I don't mind submitting a patch for it, but didn't know what you prefer here. Whatever the case be, currently the example fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant