Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prost_build::Config should be re-exported in tonic_build #1944

Open
BaxHugh opened this issue Sep 18, 2024 · 0 comments
Open

prost_build::Config should be re-exported in tonic_build #1944

BaxHugh opened this issue Sep 18, 2024 · 0 comments

Comments

@BaxHugh
Copy link

BaxHugh commented Sep 18, 2024

Feature Request

Crates

tonic-build

Motivation

tonic_build::Builder::compile_with_config
takes a prost_build::Config as an argument, which requires the additional dependency of prost-build.

Since tonic_build already re-exports prost::{compile_fds, compile_protos, configure, Builder}, I think this compile_with_config should be callable without prost-build as a separate dependency

(I need to use compile_with_config, so that I can enable_type_names.)

Proposal

I propose we additionally re-export prost_build::Config and update the documentation here to include an example of using compile_with_config.

I'll be happy to create the PR, but first want to get feedback.

Alternatives

¯_(ツ)_/¯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant