Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen visibility for CompressionEncoding utilities #1991

Open
ouillie opened this issue Oct 10, 2024 · 0 comments
Open

Loosen visibility for CompressionEncoding utilities #1991

ouillie opened this issue Oct 10, 2024 · 0 comments

Comments

@ouillie
Copy link

ouillie commented Oct 10, 2024

Feature Request

Crates

tonic

Motivation

Code re-use.

Proposal

This is an unconventional use of tonic, but I find myself wanting to use utilities in tonic/src/codec/compression.rs such as CompressionEncoding::from_encoding_header and decompress, but these functions are not public. Is there a strong objection to making these functions public? I know people would prefer to keep the API contract as small as possible, but copy-pasting this logic just doesn't feel right. More than happy to submit the PR if it would be approvable.

Alternatives

I suppose I could just copy and paste the code into another crate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant