Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numeric tags are not spec compliant for Trans component substitution #1812

Open
edkimmel opened this issue Nov 19, 2024 · 2 comments
Open

Numeric tags are not spec compliant for Trans component substitution #1812

edkimmel opened this issue Nov 19, 2024 · 2 comments

Comments

@edkimmel
Copy link

🐛 Bug Report

formatjs/formatjs#4488

tl;dr Numeric tags are not icu spec compliant and cause issues with the latest version of formatjs.

We can swap to using the { [key]: component } variation instead, but the array based method might want to be rethought or removed if it's found to not be compatible going forward.

Your Environment

  • runtime version: i.e. node v14, deno, browser xy
  • i18next version: i.e. 19.5.3
  • os: Mac, Windows, Linux
  • any other relevant information
@adrai
Copy link
Member

adrai commented Nov 19, 2024

Since react-i18next is mainly used with the i18next format, and not first-class icu format, it's still ok, to use it...
But if you need to parse your resource texts and that raises issues, you really need to use the named component approach instead...
Correct me if I'm wrong @jamuhl

@jamuhl
Copy link
Member

jamuhl commented Nov 19, 2024

agree. there are a lot of things not supported or working differentcwhen opting out of i18next format

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants