Skip to content
This repository was archived by the owner on May 12, 2025. It is now read-only.

Commit 5887ed7

Browse files
authored
feat: Disable rules already checked by the TypeScript compiler (#150)
1 parent 6144171 commit 5887ed7

File tree

1 file changed

+17
-4
lines changed

1 file changed

+17
-4
lines changed

lib/shared.js

Lines changed: 17 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -205,10 +205,23 @@ module.exports = {
205205
{
206206
files: ['*.ts', '*.tsx'],
207207
rules: {
208-
/* Using TypeScript makes it safe enough to disable the checks below */
209-
210-
// Disable ESLint-based module resolution check for improved monorepo support
211-
// https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-unresolved.md
208+
// The following rules are enabled in Airbnb config, but are already checked (more thoroughly) by the TypeScript compiler
209+
// Some of the rules also fail in TypeScript files, for example: https://github.com/typescript-eslint/typescript-eslint/issues/662#issuecomment-507081586
210+
'constructor-super': 'off',
211+
'getter-return': 'off',
212+
'no-const-assign': 'off',
213+
'no-dupe-args': 'off',
214+
'no-dupe-class-members': 'off',
215+
'no-dupe-keys': 'off',
216+
'no-func-assign': 'off',
217+
'no-new-symbol': 'off',
218+
'no-obj-calls': 'off',
219+
'no-redeclare': 'off',
220+
'no-this-before-super': 'off',
221+
'no-undef': 'off',
222+
'no-unreachable': 'off',
223+
'no-unsafe-negation': 'off',
224+
'valid-typeof': 'off',
212225
'import/no-unresolved': 'off',
213226
},
214227
},

0 commit comments

Comments
 (0)