Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI : Brand GUI as IBM #1042

Closed
14 tasks done
gtmills opened this issue Jul 23, 2019 · 14 comments
Closed
14 tasks done

GUI : Brand GUI as IBM #1042

gtmills opened this issue Jul 23, 2019 · 14 comments
Assignees
Labels
Downstream Used for stories that will only be implemented downstream GUI Catch all tag for GUI stories Milestone Tgt Overrides Epic Milestone UI Design Indicates the GUI story is for Design UI FED Indicates a GUI Front End Development story
Milestone

Comments

@gtmills
Copy link

gtmills commented Jul 23, 2019

Summary

As part of the new releases of the UI, we want a more aesthetic design of the login page. The as is design is functional, but does not convey the modernization and aesthetic that we feel represents the Power brand. We would also like to include the Power logo to establish the Power brand.

Design

Design Goals

  • Update the design to an aesthetic that will help create more trust with users
  • Establish the Power system brand into the design

InVision Prototype

Screen captures

As Is upstream experience

image

To Be upstream experience

image

As Is downstream experience

image

To be downstream experience

image

Community

FED

UX Flow / Interaction Requirements

  • Change layout
  • Move OpenBMC logo to right corner
  • Determine if we can use environmental variable to add Power brand upstream
  • Update change password layout

UI Checklist

Browser Tests (Chrome, Firefox, Safari (Mac), Edge (Windows))

  • Tested responsive layout on supported viewport sizes
  • Verified functionality works as expected, e.g. success and failure use cases
  • Resolved any JavaScript errors thrown to the console

Accessibility Tests

Test Hooks

  • Verify need for data-test-id hooks with test team
@gtmills gtmills added GUI Catch all tag for GUI stories UI FED Indicates a GUI Front End Development story labels Jul 23, 2019
@dixsie dixsie self-assigned this Jul 23, 2019
@derick-montague derick-montague changed the title GUI: FED: Brand GUI as IBM GUI : FED : Brand GUI as IBM Jul 23, 2019
@dixsie dixsie removed their assignment Jul 25, 2019
@derick-montague
Copy link
Contributor

This is specific to the login page only and favicon (use IBM Bee). Future discussion about more branding downstream (fonts, colors...).

@derick-montague derick-montague added this to the 9.5.1 milestone Aug 7, 2019
@rfrandse rfrandse modified the milestones: 9.5.1, 9.5.2 Sep 24, 2019
@derick-montague derick-montague added the Downstream Used for stories that will only be implemented downstream label Oct 30, 2019
@derick-montague derick-montague modified the milestones: 9.5.2, A.1.194 Jan 6, 2020
@derick-montague derick-montague modified the milestones: A.1.194, A.1.202 Jan 14, 2020
@rfrandse rfrandse modified the milestones: A.1.202, A.1.211 Apr 29, 2020
@derick-montague
Copy link
Contributor

The work here is understanding how the IBM logos will be pulled in from the meta layer.

@gtmills
Copy link
Author

gtmills commented Aug 10, 2020

Yeah would be nice if this could live upstream

@gtmills gtmills removed the Downstream Used for stories that will only be implemented downstream label Aug 10, 2020
@derick-montague
Copy link
Contributor

@gtmills this seems like a server-side story rather than a client-side story. I am going to assign to you and remove the FED label.

@derick-montague derick-montague removed the UI FED Indicates a GUI Front End Development story label Sep 8, 2020
@derick-montague derick-montague changed the title GUI : FED : Brand GUI as IBM GUI : Brand GUI as IBM Sep 8, 2020
@derick-montague derick-montague added UI FED Indicates a GUI Front End Development story Milestone Tgt Overrides Epic Milestone labels Nov 17, 2020
@derick-montague derick-montague changed the title GUI : Brand GUI as IBM GUI : FED : Brand GUI as IBM Nov 18, 2020
@derick-montague
Copy link
Contributor

@gtmills - I know there is some Meta layer work here, but I also see some work on pulling logos in to the login page. My feeling is that we can make a decision and share with the community. Those that are opposed to can make changes down stream. Do we know when the meta-layer work might be ready? I realize it is lower priority.

@gtmills
Copy link
Author

gtmills commented Dec 8, 2020

Yeah, I would really like us to work with the community to do something here and come up with something that works for all members. I know other companies have this use case.

Setting the .ibm.env on an IBM build is something on my plate. I will try to work that here soon. I think there will need to be additional changes for the logo unless the logos go in webui-vue? Which I'm not sure I love.

@derick-montague
Copy link
Contributor

I think there will need to be additional changes for the logo unless the logos go in webui-vue? Which I'm not sure I love.

I agree and that is true for the favicon as well.

@derick-montague derick-montague modified the milestones: A.1.211, A.1.213 Feb 23, 2021
@gtmills
Copy link
Author

gtmills commented Apr 29, 2021

I think #3099 will close this? Passing 'ibm' to webui-vue?

@derick-montague
Copy link
Contributor

I think #3099 will close this? Passing 'ibm' to webui-vue?

But I don't think we have a design for that environment.

@derick-montague derick-montague modified the milestones: A.1.213, A.1.213.7 Apr 30, 2021
@derick-montague derick-montague added UI Design Indicates the GUI story is for Design and removed prio_low UI FED Indicates a GUI Front End Development story labels Apr 30, 2021
@gtmills
Copy link
Author

gtmills commented May 13, 2021

@derick-montague Assigned you and unassigned me.

@gtmills gtmills assigned derick-montague and unassigned gtmills May 13, 2021
@derick-montague derick-montague added UI FED Indicates a GUI Front End Development story and removed UI FED Indicates a GUI Front End Development story labels May 27, 2021
@derick-montague derick-montague changed the title GUI : FED : Brand GUI as IBM GUI : Brand GUI as IBM May 28, 2021
@derick-montague
Copy link
Contributor

Updated design and added to the design review project in the webui-vue repo.

@derick-montague
Copy link
Contributor

The only concern was the title of the page that can be updated downstream.

@derick-montague derick-montague added the UI FED Indicates a GUI Front End Development story label Jul 9, 2021
@derick-montague derick-montague removed their assignment Jul 13, 2021
@derick-montague derick-montague added the Downstream Used for stories that will only be implemented downstream label Aug 16, 2021
@ibm-openbmc ibm-openbmc deleted a comment from DBurkh Aug 26, 2021
@derick-montague
Copy link
Contributor

Dylan is no longer part of the squad and his Gerrit review was abandoned. I will be finishing this story.

@derick-montague
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Downstream Used for stories that will only be implemented downstream GUI Catch all tag for GUI stories Milestone Tgt Overrides Epic Milestone UI Design Indicates the GUI story is for Design UI FED Indicates a GUI Front End Development story
Projects
None yet
Development

No branches or pull requests

5 participants