Removed usage of Component::makeFunctionControllableIfConstant

Re-golded Brayton cycle due to avoiding the bug that changed
the results.

Refs #31869

Author: joshuahansel

modules/thermal_hydraulics/doc/content/source/components/ShaftConnectedMotor.md

@@ -15,9 +15,10 @@ the time variable $t$ in these functions (and the space variables are
 discarded); therefore, the user is actually specifying the functions
 $\tau(\omega)$ and $I(\omega)$, not $\tau(t,x,y,z)$ and $I(t,x,y,z)$.
 
-If dependence on time is desired, the [ControlLogic/index.md] can be used. To
-do this, supply an arbitrary constant value instead of a function name. Then
-use a [TimeFunctionComponentControl.md]. See the `motor` component in
+If dependence on time is desired, [ControlLogic](ControlLogic/index.md) can be used. To
+do this, supply the name of a [ConstantFunction.md] and then control that function
+using the value of the time function ([GetFunctionValueControl.md] followed by [SetRealValueControl.md]).
+See the `motor` component in
 [open_brayton_cycle.i](test/tests/problems/brayton_cycle/open_brayton_cycle.i)
 for an example.
 

modules/thermal_hydraulics/src/base/FlowModel.C

@@ -89,8 +89,6 @@ FlowModel::addCommonInitialConditions()
       const Function & fn = _sim.getFunction(area_function);
       _sim.addConstantIC(AREA, fn.value(0, Point()), block);
       _sim.addConstantIC(AREA_LINEAR, fn.value(0, Point()), block);
-
-      _flow_channel.makeFunctionControllableIfConstant(area_function, "Area", "value");
     }
     else
     {

modules/thermal_hydraulics/src/closures/Closures1PhaseBase.C

@@ -24,7 +24,6 @@ void
 Closures1PhaseBase::addWallFrictionFunctionMaterial(const FlowChannel1Phase & flow_channel) const
 {
   const FunctionName & f_D_fn_name = flow_channel.getParam<FunctionName>("f");
-  flow_channel.makeFunctionControllableIfConstant(f_D_fn_name, "f");
 
   const std::string class_name = "ADWallFrictionFunctionMaterial";
   InputParameters params = _factory.getValidParams(class_name);

modules/thermal_hydraulics/src/closures/Closures1PhaseSimple.C

@@ -99,8 +99,6 @@ Closures1PhaseSimple::addMooseObjectsHeatTransfer(const HeatTransferBase & heat_
     _sim.addMaterial(
         class_name, genName(heat_transfer.name(), "Hw_material", flow_channel.name()), params);
   }
-
-  heat_transfer.makeFunctionControllableIfConstant(Hw_fn_name, "Hw");
 }
 
 void

modules/thermal_hydraulics/src/components/FlowChannel1PhaseBase.C

@@ -26,7 +26,7 @@ FlowChannel1PhaseBase::validParams()
       SlopeReconstruction1DInterface<true>::getSlopeReconstructionMooseEnum("None"),
       "Slope reconstruction type for rDG spatial discretization");
 
-  params.declareControllable("initial_p initial_T initial_vel D_h");
+  params.declareControllable("initial_p initial_T initial_vel");
   params.addParamNamesToGroup("initial_p initial_T initial_vel", "Variable initialization");
   params.addParamNamesToGroup("rdg_slope_reconstruction", "Numerical scheme");
 
@@ -118,8 +118,6 @@ FlowChannel1PhaseBase::addHydraulicDiameterMaterial()
     params.set<std::vector<std::string>>("prop_names") = {THM::HYDRAULIC_DIAMETER};
     params.set<std::vector<FunctionName>>("prop_values") = {D_h_fn_name};
     getTHMProblem().addMaterial(class_name, mat_name, params);
-
-    makeFunctionControllableIfConstant(D_h_fn_name, "D_h");
   }
   else
   {

modules/thermal_hydraulics/src/components/FlowChannelBase.C

@@ -105,7 +105,6 @@ FlowChannelBase::validParams()
       "curved flow channels, it is the (tangent) direction at the start position.");
 
   params.addPrivateParam<std::string>("component_type", "pipe");
-  params.declareControllable("A f");
 
   return params;
 }
@@ -259,7 +258,6 @@ FlowChannelBase::addCommonObjects()
       params.set<ExecFlagEnum>("execute_on") = ts_execute_on;
       const std::string aux_kernel_name = genName(name(), "area_linear_aux");
       getTHMProblem().addAuxKernel(class_name, aux_kernel_name, params);
-      makeFunctionControllableIfConstant(_area_function, "Area");
     }
     {
       const std::string class_name = "ProjectionAux";
@@ -270,7 +268,6 @@ FlowChannelBase::addCommonObjects()
       params.set<ExecFlagEnum>("execute_on") = ts_execute_on;
       const std::string aux_kernel_name = genName(name(), "area_aux");
       getTHMProblem().addAuxKernel(class_name, aux_kernel_name, params);
-      makeFunctionControllableIfConstant(_area_function, "Area");
     }
   }
 }

modules/thermal_hydraulics/src/components/HSBoundarySpecifiedTemperature.C

@@ -19,8 +19,6 @@ HSBoundarySpecifiedTemperature::validParams()
 
   params.addRequiredParam<FunctionName>("T", "Prescribed temperature [K]");
 
-  params.declareControllable("T");
-
   params.addClassDescription("Applies Dirichlet boundary conditions on a heat structure");
 
   return params;
@@ -43,6 +41,5 @@ HSBoundarySpecifiedTemperature::addMooseObjects()
     pars.set<std::vector<BoundaryName>>("boundary") = _boundary;
     pars.set<FunctionName>("function") = _T_func;
     getTHMProblem().addBoundaryCondition(class_name, genName(name(), "bc"), pars);
-    makeFunctionControllableIfConstant(_T_func, "T");
   }
 }

modules/thermal_hydraulics/src/components/HeatTransfer1PhaseBase.C

@@ -18,7 +18,6 @@ HeatTransfer1PhaseBase::validParams()
 {
   InputParameters params = HeatTransferBase::validParams();
   params.addParam<FunctionName>("Hw", "Convective heat transfer coefficient [W/(m^2-K)]");
-  params.declareControllable("Hw");
   return params;
 }
 

modules/thermal_hydraulics/src/components/HeatTransferBase.C

@@ -24,7 +24,6 @@ HeatTransferBase::validParams()
   params.addParam<bool>(
       "P_hf_transferred", false, "Is heat flux perimeter transferred from an external source?");
   params.addParam<FunctionName>("P_hf", "Heat flux perimeter [m]");
-  params.declareControllable("P_hf");
   return params;
 }
 
@@ -135,8 +134,6 @@ HeatTransferBase::addHeatedPerimeter()
       InputParameters params = _factory.getValidParams(class_name);
       params.set<FunctionName>("area_function") = _A_fn_name;
       getTHMProblem().addFunction(class_name, _P_hf_fn_name, params);
-
-      makeFunctionControllableIfConstant(_P_hf_fn_name, "P_hf");
     }
 
     if (!_app.isRestarting())

modules/thermal_hydraulics/src/components/HeatTransferFromSpecifiedTemperature1Phase.C

@@ -16,7 +16,6 @@ HeatTransferFromSpecifiedTemperature1Phase::validParams()
 {
   InputParameters params = HeatTransferFromTemperature1Phase::validParams();
   params.addRequiredParam<FunctionName>("T_wall", "Specified wall temperature [K]");
-  params.declareControllable("T_wall");
   params.addClassDescription(
       "Heat transfer connection from a fixed temperature function for 1-phase flow");
   return params;
@@ -35,8 +34,6 @@ HeatTransferFromSpecifiedTemperature1Phase::addVariables()
 
   if (!_app.isRestarting())
     getTHMProblem().addFunctionIC(_T_wall_name, _T_wall_fn_name, _flow_channel_subdomains);
-
-  makeFunctionControllableIfConstant(_T_wall_fn_name, "T_wall");
 }
 
 void