Remove CopyVec

Author: karthichockalingam

framework/include/mfem/equation_systems/EquationSystem.h

@@ -90,8 +90,6 @@ class EquationSystem : public mfem::Operator
   virtual void RecoverFEMSolution(mfem::BlockVector & trueX,
                                   Moose::MFEM::GridFunctions & gridfunctions);
 
-  void CopyVec(const mfem::Vector & x, mfem::Vector & y) { y = x; }
-
   std::vector<mfem::Array<int>> _ess_tdof_lists;
 
   const std::vector<std::string> & TrialVarNames() const { return _trial_var_names; }

framework/src/mfem/equation_systems/EquationSystem.C

@@ -327,8 +327,6 @@ EquationSystem::BuildJacobian(mfem::BlockVector & trueX, mfem::BlockVector & tru
 void
 EquationSystem::Mult(const mfem::Vector & sol, mfem::Vector & residual) const
 {
-  // const_cast<EquationSystem *>(this)->CopyVec(sol, _trueBlockSol);
-  //_trueBlockSol.mfem::Vector::operator=(sol);
   static_cast<mfem::Vector &>(_trueBlockSol) = sol;
   for (unsigned int i = 0; i < _trial_var_names.size(); i++)
   {
@@ -363,15 +361,14 @@ EquationSystem::Mult(const mfem::Vector & sol, mfem::Vector & residual) const
       _BlockResidual.GetBlock(i).SetSubVector(_ess_tdof_lists.at(i), 0.0);
     }
 
-    const_cast<EquationSystem *>(this)->CopyVec(_BlockResidual, residual);
+    residual = static_cast<mfem::Vector &>(_BlockResidual);
     const_cast<EquationSystem *>(this)->FormLinearSystem(_jacobian, _trueBlockSol, _BlockResidual);
   }
 
   residual *= -1.0;
 
   if (!_non_linear)
   {
-    //_jacobian->AddMult(sol, residual);
     residual = 0.0;
     _jacobian->Mult(sol, residual);
   }
@@ -384,14 +381,8 @@ void
 TimeDependentEquationSystem::UpdateEssDerivativeVals(const mfem::real_t & dt,
                                                      const mfem::Vector & x_old)
 {
-  // Update the old vector
-  mfem::BlockVector block_x_old;
-  block_x_old.Update(*_block_true_offsets);
   mfem::ParGridFunction u_old_gf;
-
-  // Update the old vector
-  CopyVec(x_old, block_x_old);
-  // mfem::BlockVector block_x_old(const_cast<mfem::Vector &>(x_old), *_block_true_offsets);
+  mfem::BlockVector block_x_old(const_cast<mfem::Vector &>(x_old), *_block_true_offsets);
 
   // Update the xs boundary conditions
   ApplyEssentialBCs();