-
Notifications
You must be signed in to change notification settings - Fork 9
Description
Bug Description
Current SALAMANDER debug testing builds with -Werror enabled to check for compiler warnings. With the merge of #53, this check will fail. See relevant PR result from CIVET here: https://civet.inl.gov/job/2387476/
EDIT: This occurs for scheduled Mac testing too: https://civet.inl.gov/job/2423456/
EDIT2: This can now occur with other build modes with the updated Cardinal coming in #109. See https://civet.inl.gov/job/3341090/ for an example. Striking debug from this post, since it now affects all builds. This change in behavior seems to have started occurring for Cardinal after neams-th-coe/cardinal#1212 was merged.
Steps to Reproduce
Build SALAMANDER in debug mode with CPPFLAGS += -Werror
Impact
Doesn't impact code functionality, but impinges on SALAMANDER code standards and build cleanliness.