Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Numpy>=2, Pytorch>=2.3 #346

Merged
merged 4 commits into from
Mar 24, 2025
Merged

Switch to Numpy>=2, Pytorch>=2.3 #346

merged 4 commits into from
Mar 24, 2025

Conversation

fabiocat93
Copy link

@fabiocat93 fabiocat93 commented Mar 20, 2025

making dependency constraints less strict to support numpy 2. This should be considered as a start, but needs further edits. Thank you for your help

Fixes #345

@fabiocat93 fabiocat93 closed this Mar 20, 2025
@fabiocat93 fabiocat93 reopened this Mar 20, 2025
@juangon
Copy link

juangon commented Mar 24, 2025

+1

@eginhard eginhard changed the title Support numpy 2 Switch to Numpy>=2 Mar 24, 2025
@eginhard eginhard changed the title Switch to Numpy>=2 Switch to Numpy>=2, Pytorch>=2.3 Mar 24, 2025
Copy link
Member

@eginhard eginhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! I increased some additional minimum package versions, notably Numpy 2 is only supported from Pytorch 2.3. I also added an unrelated fix for the new librosa 0.11.0 that caused test failures.

@fabiocat93
Copy link
Author

This is great! Looking forward to try the new release once it's published!

@eginhard eginhard merged commit 97e4deb into idiap:dev Mar 24, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] Numpy v2 compatibility
3 participants