Refactor logging: Remove logging functionality across all packages to make room for the new UI components

Author: wiebe-vandendriessche

README.md

@@ -180,10 +180,6 @@ Intended to interactively fill missing metadata fields.
 - Current status: stubbed / not implemented.
 - Future work: implement user prompting and (optionally) model card fetching.
 
-### `internal/logging`
-
-Small opt-in logger used across internal packages (writes only when a writer is configured).
-
 ### `internal/ui`
 
 Very small ANSI-color helper used for banners and colored log prefixes.

cmd/completeness.go

@@ -9,7 +9,6 @@ import (
 
 	"github.com/idlab-discover/AIBoMGen-cli/internal/completeness"
 	bomio "github.com/idlab-discover/AIBoMGen-cli/internal/io"
-	"github.com/idlab-discover/AIBoMGen-cli/internal/metadata"
 	"github.com/idlab-discover/AIBoMGen-cli/internal/ui"
 )
 
@@ -33,11 +32,7 @@ var completenessCmd = &cobra.Command{
 
 		// Wire internal package logging based on log level.
 		if level != "quiet" {
-			lw := cmd.ErrOrStderr()
-			completeness.SetLogger(lw)
-			if level == "debug" {
-				metadata.SetLogger(lw)
-			}
+			// Logging removed
 		}
 
 		// Get input path and format from viper

cmd/enrich.go

@@ -4,11 +4,8 @@ import (
 	"fmt"
 	"strings"
 
-	"github.com/idlab-discover/AIBoMGen-cli/internal/completeness"
 	"github.com/idlab-discover/AIBoMGen-cli/internal/enricher"
-	"github.com/idlab-discover/AIBoMGen-cli/internal/fetcher"
 	bomio "github.com/idlab-discover/AIBoMGen-cli/internal/io"
-	"github.com/idlab-discover/AIBoMGen-cli/internal/metadata"
 	"github.com/spf13/cobra"
 	"github.com/spf13/viper"
 )
@@ -47,13 +44,7 @@ from Hugging Face API and README before enrichment.`,
 
 		// Wire internal package logging
 		if level != "quiet" {
-			lw := cmd.ErrOrStderr()
-			enricher.SetLogger(lw)
-			completeness.SetLogger(lw)
-			fetcher.SetLogger(lw)
-			if level == "debug" {
-				metadata.SetLogger(lw)
-			}
+			// Logging removed
 		}
 
 		// Read existing BOM

cmd/generate.go

@@ -12,11 +12,8 @@ import (
 	"github.com/spf13/cobra"
 	"github.com/spf13/viper"
 
-	"github.com/idlab-discover/AIBoMGen-cli/internal/builder"
-	"github.com/idlab-discover/AIBoMGen-cli/internal/fetcher"
 	"github.com/idlab-discover/AIBoMGen-cli/internal/generator"
 	bomio "github.com/idlab-discover/AIBoMGen-cli/internal/io"
-	"github.com/idlab-discover/AIBoMGen-cli/internal/metadata"
 	"github.com/idlab-discover/AIBoMGen-cli/internal/scanner"
 	"github.com/idlab-discover/AIBoMGen-cli/internal/ui"
 )
@@ -131,12 +128,7 @@ func runGenerate(cmd *cobra.Command, args []string) error {
 
 	// Wire internal package logging for debug mode
 	if level == "debug" {
-		lw := cmd.ErrOrStderr()
-		fetcher.SetLogger(lw)
-		metadata.SetLogger(lw)
-		builder.SetLogger(lw)
-		scanner.SetLogger(lw)
-		generator.SetLogger(lw)
+		// Logging removed
 	}
 
 	// Get HF settings

cmd/validate.go

@@ -4,9 +4,7 @@ import (
 	"fmt"
 	"strings"
 
-	"github.com/idlab-discover/AIBoMGen-cli/internal/completeness"
 	bomio "github.com/idlab-discover/AIBoMGen-cli/internal/io"
-	"github.com/idlab-discover/AIBoMGen-cli/internal/metadata"
 	"github.com/idlab-discover/AIBoMGen-cli/internal/ui"
 	"github.com/idlab-discover/AIBoMGen-cli/internal/validator"
 	"github.com/spf13/cobra"
@@ -47,12 +45,7 @@ var validateCmd = &cobra.Command{
 
 		// Wire internal package logging based on log level.
 		if level != "quiet" {
-			lw := cmd.ErrOrStderr()
-			validator.SetLogger(lw)
-			if level == "debug" {
-				metadata.SetLogger(lw)
-				completeness.SetLogger(lw)
-			}
+			// Logging removed
 		}
 
 		// Get format from viper

internal/builder/bom_builder.go

@@ -17,7 +17,6 @@ func NewBOMBuilder(opts Options) *BOMBuilder {
 }
 
 func (b BOMBuilder) Build(ctx BuildContext) (*cdx.BOM, error) {
-	logf(ctx.ModelID, "build start")
 
 	comp := buildMetadataComponent(ctx)
 
@@ -43,13 +42,11 @@ func (b BOMBuilder) Build(ctx BuildContext) (*cdx.BOM, error) {
 		metadata.ApplyFromSources(spec, src, tgt)
 	}
 
-	logf(ctx.ModelID, "build ok")
 	return bom, nil
 }
 
 // BuildDataset builds a dataset component into BOM.components
 func (b BOMBuilder) BuildDataset(ctx DatasetBuildContext) (*cdx.Component, error) {
-	logf(ctx.DatasetID, "build dataset start")
 
 	comp := buildDatasetComponent(ctx)
 
@@ -70,7 +67,6 @@ func (b BOMBuilder) BuildDataset(ctx DatasetBuildContext) (*cdx.Component, error
 		metadata.ApplyDatasetFromSources(spec, src, tgt)
 	}
 
-	logf(ctx.DatasetID, "build dataset ok")
 	return comp, nil
 }
 

internal/builder/bom_builder_test.go

@@ -1,7 +1,6 @@
 package builder
 
 import (
-	"io"
 	"strings"
 	"testing"
 
@@ -96,8 +95,6 @@ func TestBuildMetadataComponent_SetsTypeAndNonNilModelCard(t *testing.T) {
 // Test Build function creates BOM with metadata component
 func TestBOMBuilder_Build_CreatesBOMWithMetadataComponent(t *testing.T) {
 	b := NewBOMBuilder(DefaultOptions())
-	SetLogger(io.Discard)
-	t.Cleanup(func() { SetLogger(nil) })
 
 	// Keep Scan.Name empty so registry won't override the name.
 	ctx := BuildContext{

internal/builder/logging.go

@@ -59,26 +59,18 @@ func (r Report) ToUIReport() ui.CompletenessReport {
 // PrintReport writes the report to the configured logger writer.
 // If no logger writer is configured, it produces no output.
 func PrintReport(r Report) {
-	logf("Model score=%.1f%% (%d/%d)", r.Score*100, r.Passed, r.Total)
 
 	if len(r.MissingRequired) > 0 {
-		logf("missing required: %s", joinKeys(r.MissingRequired))
 	}
 	if len(r.MissingOptional) > 0 {
-		logf("missing optional: %s", joinKeys(r.MissingOptional))
 	}
 
 	// Print dataset reports if any
 	if len(r.DatasetReports) > 0 {
-		logf("")
-		logf("Dataset Components:")
-		for dsName, dsReport := range r.DatasetReports {
-			logf("  %s: score=%.1f%% (%d/%d)", dsName, dsReport.Score*100, dsReport.Passed, dsReport.Total)
+		for _, dsReport := range r.DatasetReports {
 			if len(dsReport.MissingRequired) > 0 {
-				logf("    missing required: %s", joinDatasetKeys(dsReport.MissingRequired))
 			}
 			if len(dsReport.MissingOptional) > 0 {
-				logf("    missing optional: %s", joinDatasetKeys(dsReport.MissingOptional))
 			}
 		}
 	}