Encoding equality to equivalence, and key equivalence #393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deeglaze
requested review from
henkbirkholz,
thomas-fossati,
yogeshbdeshpande and
nedmsmith
as code owners
nedmsmith
reviewed
Feb 25, 2025
| @@ -2466,11 +2464,11 @@ If any of the fields does not match, then the condition ECT does not match the A | |||
| The Verifier SHALL compare each field which is present in the condition ECT `environment-map` against the corresponding field in the ACS entry `environment-map` using binary comparison. | |||
| Before performing the binary comparison, the Verifier SHOULD convert both `environment-map` fields into a form which meets CBOR Core Deterministic Encoding Requirements {{-cbor}}. | |||
|
|
|||
| If all fields which are present in the condition ECT `environment-map` are present in the ACS entry and are binary identical, then the environments match. | |||
| If all fields which are present in the condition ECT `environment-map` are present in the ACS entry and are equivalent, then the environments match. | |||
There was a problem hiding this comment.
Should we not qualify what equivalent means?
There was a problem hiding this comment.
I think that we can revert the equivalence text for ECTs since there's already a translation to them.
There was a problem hiding this comment.
I've gone back to the original text about equivalence to clarify the "typically" wording.
yogeshbdeshpande
approved these changes
Jun 11, 2025
| @@ -2285,7 +2283,7 @@ See {{sec-authority}}. | |||
|
|
|||
| If the merged `measurement-values-map` contains duplicate codepoints and the | |||
| measurement values are equivalent, then duplicate claims SHOULD be omitted. | |||
| Equivalence typically means values MUST be binary identical. | |||
| Equivalence means the values MUST be binary identical unless they are from a profile extension that defines its own equivalence relation. | |||
There was a problem hiding this comment.
Move this to a top level Equivalence definition, and check, whether it is applicable in all sections!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues #375, #388.