Skip to content

Commit 8957afd

Browse files
authored
ci: merge main to release (#8778)
2 parents 1b4afc9 + 589ba7a commit 8957afd

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

66 files changed

+1288
-482
lines changed

.devcontainer/docker-compose.extend.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
version: '3.8'
2-
31
services:
42
app:
53
environment:

.github/ISSUE_TEMPLATE/config.yml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
blank_issues_enabled: false
2-
contact_links:
3-
- name: Help and questions
4-
url: https://github.com/ietf-tools/datatracker/discussions/categories/help-questions
5-
about: Need help? Have a question on setting up the project or its usage?
6-
- name: Discuss new ideas
7-
url: https://github.com/ietf-tools/datatracker/discussions/categories/ideas
8-
about: Submit ideas for new features or improvements to be discussed.
1+
blank_issues_enabled: false
2+
contact_links:
3+
- name: Help and questions
4+
url: https://github.com/ietf-tools/datatracker/discussions/categories/help-questions
5+
about: Need help? Have a question on setting up the project or its usage?
6+
- name: Discuss new ideas
7+
url: https://github.com/ietf-tools/datatracker/discussions/categories/ideas
8+
about: Submit ideas for new features or improvements to be discussed.

.github/workflows/build-base-app.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ jobs:
5151
push: true
5252
tags: |
5353
ghcr.io/ietf-tools/datatracker-app-base:${{ env.IMGVERSION }}
54-
ghcr.io/ietf-tools/datatracker-app-base:latest
54+
${{ github.ref == 'refs/heads/main' && 'ghcr.io/ietf-tools/datatracker-app-base:latest' || '' }}
5555
5656
- name: Update version references
5757
run: |
@@ -61,6 +61,6 @@ jobs:
6161
- name: Commit CHANGELOG.md
6262
uses: stefanzweifel/git-auto-commit-action@v5
6363
with:
64-
branch: main
64+
branch: ${{ github.ref_name }}
6565
commit_message: 'ci: update base image target version to ${{ env.IMGVERSION }}'
6666
file_pattern: dev/build/Dockerfile dev/build/TARGET_BASE

.github/workflows/build-mq-broker.yml

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,13 @@ on:
88
- 'dev/mq/**'
99
- '.github/workflows/build-mq-broker.yml'
1010

11-
workflow_dispatch:
12-
13-
env:
14-
RABBITMQ_VERSION: 3.12-alpine
11+
workflow_dispatch:
12+
inputs:
13+
rabbitmq_version:
14+
description: 'RabbitMQ Version'
15+
default: '3.13-alpine'
16+
required: true
17+
type: string
1518

1619
jobs:
1720
publish:
@@ -45,7 +48,7 @@ jobs:
4548
file: dev/mq/Dockerfile
4649
platforms: linux/amd64,linux/arm64
4750
push: true
48-
build-args: RABBITMQ_VERSION=${{ env.RABBITMQ_VERSION }}
51+
build-args: RABBITMQ_VERSION=${{ inputs.rabbitmq_version }}
4952
tags: |
50-
ghcr.io/ietf-tools/datatracker-mq:${{ env.RABBITMQ_VERSION }}
53+
ghcr.io/ietf-tools/datatracker-mq:${{ inputs.rabbitmq_version }}
5154
ghcr.io/ietf-tools/datatracker-mq:latest

.github/workflows/build.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ jobs:
9797
echo "IS_RELEASE=true" >> $GITHUB_ENV
9898
9999
- name: Create Draft Release
100-
uses: ncipollo/release-action@v1.15.0
100+
uses: ncipollo/release-action@v1.16.0
101101
if: ${{ github.ref_name == 'release' }}
102102
with:
103103
prerelease: true
@@ -185,7 +185,7 @@ jobs:
185185

186186
- name: Download a Coverage Results
187187
if: ${{ github.event.inputs.skiptests == 'false' || github.ref_name == 'release' }}
188-
uses: actions/[email protected].8
188+
uses: actions/[email protected].9
189189
with:
190190
name: coverage
191191

@@ -292,7 +292,7 @@ jobs:
292292

293293
- name: Download Coverage Results
294294
if: ${{ github.event.inputs.skiptests == 'false' || github.ref_name == 'release' }}
295-
uses: actions/[email protected].8
295+
uses: actions/[email protected].9
296296
with:
297297
name: coverage
298298

@@ -316,7 +316,7 @@ jobs:
316316
histCoveragePath: historical-coverage.json
317317

318318
- name: Create Release
319-
uses: ncipollo/release-action@v1.15.0
319+
uses: ncipollo/release-action@v1.16.0
320320
if: ${{ env.SHOULD_DEPLOY == 'true' }}
321321
with:
322322
allowUpdates: true
@@ -329,7 +329,7 @@ jobs:
329329
token: ${{ secrets.GITHUB_TOKEN }}
330330

331331
- name: Update Baseline Coverage
332-
uses: ncipollo/release-action@v1.15.0
332+
uses: ncipollo/release-action@v1.16.0
333333
if: ${{ github.event.inputs.updateCoverage == 'true' || github.ref_name == 'release' }}
334334
with:
335335
allowUpdates: true
@@ -407,7 +407,7 @@ jobs:
407407
- uses: actions/checkout@v4
408408

409409
- name: Download a Release Artifact
410-
uses: actions/[email protected].8
410+
uses: actions/[email protected].9
411411
with:
412412
name: release-${{ env.PKG_VERSION }}
413413

.github/workflows/tests-az.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ jobs:
3838
ssh-keyscan -t rsa $vminfo >> ~/.ssh/known_hosts
3939
4040
- name: Remote SSH into VM
41-
uses: appleboy/ssh-action@7eaf76671a0d7eec5d98ee897acda4f968735a17
41+
uses: appleboy/ssh-action@2ead5e36573f08b82fbfce1504f1a4b05a647c6f
4242
env:
4343
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
4444
with:

README.md

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@
4444

4545
This project is following the standard **Git Feature Workflow** development model. Learn about all the various steps of the development workflow, from creating a fork to submitting a pull request, in the [Contributing](https://github.com/ietf-tools/.github/blob/main/CONTRIBUTING.md) guide.
4646

47+
> [!TIP]
4748
> Make sure to read the [Styleguides](https://github.com/ietf-tools/.github/blob/main/CONTRIBUTING.md#styleguides) section to ensure a cohesive code format across the project.
4849
4950
You can submit bug reports, enhancement and new feature requests in the [discussions](https://github.com/ietf-tools/datatracker/discussions) area. Accepted tickets will be converted to issues.
@@ -52,7 +53,8 @@ You can submit bug reports, enhancement and new feature requests in the [discuss
5253

5354
Click the <kbd>Fork</kbd> button in the top-right corner of the repository to create a personal copy that you can work on.
5455

55-
> Note that some GitHub Actions might be enabled by default in your fork. You should disable them by going to **Settings** > **Actions** > **General** and selecting **Disable actions** (then Save).
56+
> [!NOTE]
57+
> Some GitHub Actions might be enabled by default in your fork. You should disable them by going to **Settings** > **Actions** > **General** and selecting **Disable actions** (then Save).
5658
5759
#### Git Cloning Tips
5860

@@ -104,7 +106,8 @@ Read the [Docker Dev Environment](docker/README.md) guide to get started.
104106

105107
Nightly database dumps of the datatracker are available as Docker images: `ghcr.io/ietf-tools/datatracker-db:latest`
106108

107-
> Note that to update the database in your dev environment to the latest version, you should run the `docker/cleandb` script.
109+
> [!TIP]
110+
> In order to update the database in your dev environment to the latest version, you should run the `docker/cleandb` script.
108111

109112
### Blob storage for dev/test
110113

@@ -248,6 +251,7 @@ From a datatracker container, run the command:
248251
./ietf/manage.py test --settings=settings_test
249252
```
250253

254+
> [!TIP]
251255
> You can limit the run to specific tests using the `--pattern` argument.
252256

253257
### Frontend Tests
@@ -257,11 +261,13 @@ Frontend tests are done via Playwright. There're 2 different type of tests:
257261
- Tests that test Vue pages / components and run natively without any external dependency.
258262
- Tests that require a running datatracker instance to test against (usually legacy views).
259263
264+
> [!IMPORTANT]
260265
> Make sure you have Node.js 16.x or later installed on your machine.
261266
262267
#### Run Vue Tests
263268
264-
> :warning: All commands below **MUST** be run from the `./playwright` directory, unless noted otherwise.
269+
> [!WARNING]
270+
> All commands below **MUST** be run from the `./playwright` directory, unless noted otherwise.
265271
266272
1. Run **once** to install dependencies on your system:
267273
```sh
@@ -294,7 +300,8 @@ Frontend tests are done via Playwright. There're 2 different type of tests:
294300
295301
First, you need to start a datatracker instance (dev or prod), ideally from a docker container, exposing the 8000 port.
296302
297-
> :warning: All commands below **MUST** be run from the `./playwright` directory.
303+
> [!WARNING]
304+
> All commands below **MUST** be run from the `./playwright` directory.
298305
299306
1. Run **once** to install dependencies on your system:
300307
```sh

client/agenda/AgendaDetailsModal.vue

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -327,7 +327,6 @@ async function fetchSessionMaterials () {
327327
border-radius: 5px;
328328
329329
.badge {
330-
width: 30px;
331330
font-size: .7em;
332331
background-color: $yellow-200;
333332
border-bottom: 1px solid $yellow-500;

client/agenda/AgendaMobileBar.vue

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -124,11 +124,11 @@ const downloadIcsOptions = [
124124
125125
function jumpToDay (dayId) {
126126
if (dayId === 'now') {
127-
const lastEventId = agendaStore.findCurrentEventId()
128-
if (lastEventId) {
129-
document.getElementById(`agenda-rowid-${lastEventId}`)?.scrollIntoView(true)
127+
const nowEventId = agendaStore.findNowEventId()
128+
if (nowEventId) {
129+
document.getElementById(`agenda-rowid-${nowEventId}`)?.scrollIntoView(true)
130130
} else {
131-
message.warning('There is no event happening right now.')
131+
message.warning('There is no event happening right now or in the future.')
132132
}
133133
} else {
134134
document.getElementById(dayId)?.scrollIntoView(true)

client/agenda/AgendaQuickAccess.vue

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -204,12 +204,12 @@ function scrollToDay (daySlug, ev) {
204204
}
205205
206206
function scrollToNow (ev) {
207-
const lastEventId = agendaStore.findCurrentEventId()
207+
const nowEventId = agendaStore.findNowEventId()
208208
209-
if (lastEventId) {
210-
document.getElementById(`agenda-rowid-${lastEventId}`)?.scrollIntoView(true)
209+
if (nowEventId) {
210+
document.getElementById(`agenda-rowid-${nowEventId}`)?.scrollIntoView(true)
211211
} else {
212-
message.warning('There is no event happening right now.')
212+
message.warning('There is no event happening right now or in the future.')
213213
}
214214
}
215215

0 commit comments

Comments
 (0)