-
Notifications
You must be signed in to change notification settings - Fork 555
feat: improve apply_to_all handling in upload forms #8680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: improve apply_to_all handling in upload forms #8680
Conversation
Hi Peter - thanks for this. |
It was just that I (not a chair) was submitting slides, and asked our WG chair what that checkbox meant, because it wasn't clear to me. It was explained to me, together with the comment that they (the WG chairs) always untick that box during approval because slide decks usually go to only the session where they will be presented. So I thought it makes sense to set it to false initially. As for what else to do, I think nothing is really needed beyond making clear what the checkbox means. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8680 +/- ##
==========================================
- Coverage 88.88% 88.80% -0.08%
==========================================
Files 312 314 +2
Lines 40891 41243 +352
==========================================
+ Hits 36345 36627 +282
- Misses 4546 4616 +70 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Please see https://mailarchive.ietf.org/arch/browse/wgchairs/?q=subject%3A(apply%20to%20all%20sessions) |
Fine with me. However,
It seems to be that the default ideally should be a WG property, but my gut feeling is that that's unnecessarily complex. |
I'll shift this to draft as part of holding it aside. |
apply_to_all
field because old text caused confusion ("what is being applied?")apply_to_all=False
by default for uploading slides (as per the apparently common usecase)