-
Notifications
You must be signed in to change notification settings - Fork 555
feat: Distinguish I-Ds on WG plate from I-Ds on IESG plate #9214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
We can define a sort that is not alphabetical with very little work. I think something like "Drafts with the IESG" would be a better heading. I don't think we currently can get into a position where we have a non- This will have enough impact that the PR should come with tests. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9214 +/- ##
==========================================
- Coverage 88.74% 88.73% -0.01%
==========================================
Files 320 320
Lines 41674 41677 +3
==========================================
- Hits 36985 36984 -1
- Misses 4689 4693 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I will finally have to dig in this part of the code ;-) |
Humm the plural filter won't work then :-( moreover there should then be a RFC Editor search_heading |
The plural decoration is really overkill for section headers like this - a section that has only one draft but with "drafts" in the section header isn't going damage the reader's comprehension. "With the RFC Editor" seems good too, but this looks like something that needs some design and definitely some tests to make sure we're doing the right thing with drafts of all provenance. |
shifting to draft while aspects discussed in-person are addressed. |
@rjsparks when you have time, you may want to review the extended test coverage. |
Address #8783
Added a new search_heading with "Outside of the WG Internet-Draft" when IESG-state != idexists
Using "outside" will make the I-Ds outside of the WG plate be listed after "Active" and "Expired" but before "RFC"