Skip to content

feat: Distinguish I-Ds on WG plate from I-Ds on IESG plate #9214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

evyncke
Copy link
Collaborator

@evyncke evyncke commented Jul 22, 2025

Address #8783

Added a new search_heading with "Outside of the WG Internet-Draft" when IESG-state != idexists

Using "outside" will make the I-Ds outside of the WG plate be listed after "Active" and "Expired" but before "RFC"

@rjsparks
Copy link
Member

We can define a sort that is not alphabetical with very little work.

I think something like "Drafts with the IESG" would be a better heading.

I don't think we currently can get into a position where we have a non-idexists iesg state for drafts in other streams, but we would have a problem with search results for individual submissions with the IESG that would today appear in related documents.

This will have enough impact that the PR should come with tests.

Copy link

codecov bot commented Jul 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.73%. Comparing base (ea8377d) to head (371c7e7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9214      +/-   ##
==========================================
- Coverage   88.74%   88.73%   -0.01%     
==========================================
  Files         320      320              
  Lines       41674    41677       +3     
==========================================
- Hits        36985    36984       -1     
- Misses       4689     4693       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@evyncke
Copy link
Collaborator Author

evyncke commented Jul 22, 2025

This will have enough impact that the PR should come with tests.

I will finally have to dig in this part of the code ;-)

@evyncke
Copy link
Collaborator Author

evyncke commented Jul 22, 2025

I think something like "Drafts with the IESG" would be a better heading.

Humm the plural filter won't work then :-( moreover there should then be a RFC Editor search_heading

@rjsparks
Copy link
Member

The plural decoration is really overkill for section headers like this - a section that has only one draft but with "drafts" in the section header isn't going damage the reader's comprehension.

"With the RFC Editor" seems good too, but this looks like something that needs some design and definitely some tests to make sure we're doing the right thing with drafts of all provenance.

@rjsparks rjsparks marked this pull request as draft July 23, 2025 14:03
@rjsparks
Copy link
Member

shifting to draft while aspects discussed in-person are addressed.

@evyncke evyncke marked this pull request as ready for review July 31, 2025 05:16
@evyncke
Copy link
Collaborator Author

evyncke commented Jul 31, 2025

@rjsparks when you have time, you may want to review the extended test coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants