Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with nested interactive elements in the Modal component #2123

Open
julianguyen opened this issue Oct 1, 2022 · 4 comments · May be fixed by #2333
Open

Fix issue with nested interactive elements in the Modal component #2123

julianguyen opened this issue Oct 1, 2022 · 4 comments · May be fixed by #2333

Comments

@julianguyen
Copy link
Member

julianguyen commented Oct 1, 2022

Description

In the Modal component (code), the element that opens the modal has a role="button" on it. This causes a problem because the nested element should be an interactive element like a button or link. This will reduce the quality of the screen-reader experience.

We want to remove this role if the child element has a role and is an interactive element. For safe measure, keep role="button" if the child element doesn't have a role and is an interactive element.


Please assign yourself (via the Assignees dropdown), if you do want to work on this issue. Can't find yourself? You need to join our organization.

Check out our Picking Up Issues guide if you haven't already!

@AudreyKj
Copy link
Contributor

AudreyKj commented Oct 1, 2022

Hello! I just assigned myself and would like to work on this :)

@julianguyen
Copy link
Member Author

Awesome, thanks @AudreyKj! Hope you're doing well :)

@shivansh84ya
Copy link

Hi @julianguyen ,
I would like to work on this issue. Could you please assign it to me?
Thanks!

@patrikkr858 patrikkr858 self-assigned this Oct 9, 2024
@patrikkr858
Copy link

Based on the conversation with @julianguyen on Slack, I’ve decided to work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants