Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the location of language menu #2322

Open
asem-hamid opened this issue Oct 3, 2024 · 5 comments
Open

Change the location of language menu #2322

asem-hamid opened this issue Oct 3, 2024 · 5 comments

Comments

@asem-hamid
Copy link
Contributor

image
image

I think the standard practice is to place the language menu on the right side of the navbar. This positioning aligns with common design patterns, making it easier for visitors to locate and switch languages quickly.

Copy link

welcome bot commented Oct 3, 2024

Thank you for opening this issue with us! If you haven't already, please follow these next steps to officially join our contributor community.

@mohit-nagaraj
Copy link
Member

mohit-nagaraj commented Oct 4, 2024

wht do others think? this should be changed based on wht most of the people agree to @julianguyen

@julianguyen
Copy link
Member

This is good feedback! I like the idea of it being in the nav bar too. You'll have to consider what this looks like on desktop, tablet, and mobile breakpoints.

@shivamsawarn2003
Copy link

This is really a great idea, i am working on it.

@mohit-nagaraj
Copy link
Member

Hey @shivamsawarn2003 I have started working on it already i have responsiveness left to check will be raising pr in few days. U can check out my fork if you want to help me out with something

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants