Skip to content

Commit 145d2b3

Browse files
chore: use new api (backport #4816) (#4818)
* chore: use new api (#4816) * chore: use new api * improvements * cl * updates (cherry picked from commit 99735e0) # Conflicts: # ignite/internal/announcements/announcement_test.go * fix conflicts --------- Co-authored-by: julienrbrt <[email protected]>
1 parent 990a42a commit 145d2b3

File tree

7 files changed

+15
-8
lines changed

7 files changed

+15
-8
lines changed

changelog.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,16 @@
22

33
## Unreleased
44

5+
## [`v28.11.2`](https://github.com/ignite/cli/releases/tag/v28.11.2)
6+
7+
### Changes
8+
9+
- [#4816](https://github.com/ignite/cli/pull/4816) Improve announcements UI.
10+
511
## [`v28.11.1`](https://github.com/ignite/cli/releases/tag/v28.11.1)
612

13+
### Changes
14+
715
- [#4813](https://github.com/ignite/cli/pull/4813) Fetch fallback buf token.
816

917
## [`v28.11.0`](https://github.com/ignite/cli/releases/tag/v28.11.0)

ignite/cmd/bubblemodel/chain_serve.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,7 @@ func (m ChainServe) renderQuitView() string {
260260
view.WriteRune('\n')
261261
}
262262

263-
fmt.Fprintf(&view, "%s %s\n", icons.Info, colors.Info("Stopped"))
263+
fmt.Fprintf(&view, "%s %s\n\n", icons.Info, colors.Info("Stopped"))
264264
view.WriteString(announcements.Fetch())
265265

266266
return view.String()

ignite/cmd/cmd.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,9 +59,7 @@ To get started, create a blockchain:
5959
6060
$ ignite scaffold chain example
6161
62-
Announcements:
63-
%s
64-
`, announcements.Fetch()),
62+
%s`, announcements.Fetch()),
6563
SilenceUsage: true,
6664
SilenceErrors: true,
6765
Args: cobra.MinimumNArgs(0), // note(@julienrbrt): without this, ignite __complete(noDesc) hidden commands are not working.

ignite/internal/analytics/analytics.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ import (
2121
)
2222

2323
const (
24-
telemetryEndpoint = "https://matomo-cli.ignite.com"
24+
telemetryEndpoint = "https://api.ignite.com/v1/telemetry"
2525
envDoNotTrack = "DO_NOT_TRACK"
2626
envCI = "CI"
2727
envGitHubActions = "GITHUB_ACTIONS"

ignite/internal/announcements/announcement.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ func Fetch() string {
4343
}
4444

4545
var out strings.Builder
46-
fmt.Fprintf(&out, "\n%s %s\n", icons.Announcement, "Announcements")
46+
fmt.Fprintf(&out, "%s\n\n", "Announcements:")
4747

4848
for _, msg := range data.Announcements {
4949
fmt.Fprintf(&out, "%s %s\n", icons.Bullet, msg.Text)

ignite/internal/announcements/announcement_test.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import (
77
"testing"
88

99
"github.com/ignite/cli/v28/ignite/internal/announcements"
10+
"github.com/ignite/cli/v28/ignite/pkg/cliui/icons"
1011
)
1112

1213
func TestFetchAnnouncements(t *testing.T) {
@@ -22,7 +23,7 @@ func TestFetchAnnouncements(t *testing.T) {
2223
name: "successful retrieval",
2324
mockResponse: `{"version":1,"announcements":[{"id":"1744230503810","text":"New Ignite announcement: v1.0.0 released!","timestamp":"2025-04-09T20:28:23.810Z","user":"announcement-bot"}]}`,
2425
statusCode: http.StatusOK,
25-
expected: "\n🗣️ Announcements\n New Ignite announcement: v1.0.0 released!\n",
26+
expected: fmt.Sprintf("Announcements:\n\n%s New Ignite announcement: v1.0.0 released!\n", icons.Bullet),
2627
},
2728
{
2829
name: "empty announcements",

ignite/internal/buf/buf.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import (
88
"github.com/ignite/cli/v28/ignite/pkg/errors"
99
)
1010

11-
var BufTokenURL = "https://buf.ignite.com" //nolint:gosec // URL is hardcoded and not user-provided
11+
var BufTokenURL = "https://api.ignite.com/v1/buf" //nolint:gosec // URL is hardcoded and not user-provided
1212

1313
// FetchToken fetches the buf token from the Ignite API.
1414
func FetchToken() (string, error) {

0 commit comments

Comments
 (0)