Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Log API fetches for all rooms #228

Open
Fishbowler opened this issue Jul 6, 2022 · 0 comments
Open

Ensure Log API fetches for all rooms #228

Fishbowler opened this issue Jul 6, 2022 · 0 comments

Comments

@Fishbowler
Copy link
Member

#222 spotted some deprecated methods after bumping the minimum Openfire version
#223 spotted that the reason getChatRooms() was deprecated was because it fetched in-memory chat rooms only (and had been replaced with an equivalent getActiveChatRooms()

Update the implementation to inspect all rooms when needed, not just the ones in memory/cache.
Beware memory utilisation - iterating over all unused MUCs in the DB could be expensive.

.filter(s -> s.getActiveChatRooms().stream().anyMatch(r -> r.isLogEnabled() && r.isPublicRoom()))

final List<String> roomNames = multiUserChatService.getActiveChatRooms().stream()

Fishbowler added a commit to Fishbowler/openfire-monitoring-plugin that referenced this issue Jul 6, 2022
guusdk pushed a commit that referenced this issue Jul 6, 2022
guusdk pushed a commit to guusdk/openfire-monitoring-plugin that referenced this issue Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant