Merge branch 'main' into copilot/autogenerate-non-callback-functions

Author: krlmlr

.github/copilot-instructions.md

@@ -2,11 +2,33 @@
 
 > **Note**: For general development guidelines, code style conventions, and AI agent instructions, see [`AGENTS.md`](../AGENTS.md) in the repository root.
 
+## Project Overview
+
+igraph/rigraph is an R package for network analysis and graph theory with a C/C++ backend.
+
 ## Common Commands for Copilot Chat
 
 - Load for development: `pkgload::load_all()`
 - Run tests: `testthat::test_local(reporter = "check")`
+- Run tests for a single file: `testthat::test_local(filter = "foo", reporter = "check")`
 - Format code: `air format .`
 - Update documentation: `devtools::document()`
+- Build package: `devtools::build()`
+- Check package: `devtools::check()`
+
+## Key Conventions
+
+- Use `snake_case` for functions and arguments
+- Follow tidyverse style guide
+- Use roxygen2 with Markdown for documentation
+- Run `air format .` before committing
+- Add tests for all new functionality
+- Use explicit package prefixes (e.g., `withr::local_db_connection()`)
+
+## Important Files
+
+- **Do not modify directly**: `src/rinterface.c`, `R/aaa-auto.R` (generated by Stimulus)
+- Update generated files: `make -f Makefile-cigraph src/rinterface.c R/aaa-auto.R`
+- See `tools/README.md` for Stimulus framework guidelines
 
-Refer to `AGENTS.md` for more instructions.
+Refer to `AGENTS.md` for complete instructions.

.github/workflows/copilot-setup-steps.yaml

@@ -6,10 +6,10 @@ on:
   workflow_dispatch:
   push:
     paths:
-      - .github/workflows/copilot-setup-steps.yml
+      - .github/workflows/copilot-setup-steps.yaml
   pull_request:
     paths:
-      - .github/workflows/copilot-setup-steps.yml
+      - .github/workflows/copilot-setup-steps.yaml
 
 jobs:
   # The job MUST be called `copilot-setup-steps` or it will not be picked up by Copilot.

R/aaa-auto.R

@@ -12959,7 +12959,9 @@ almost_equals_impl <- function(
   eps
 ) {
   # Argument checks
-
+  a <- as.numeric(a)
+  b <- as.numeric(b)
+  eps <- as.numeric(eps)
 
   on.exit(.Call(R_igraph_finalizer))
   # Function call
@@ -12979,7 +12981,9 @@ cmp_epsilon_impl <- function(
   eps
 ) {
   # Argument checks
-
+  a <- as.numeric(a)
+  b <- as.numeric(b)
+  eps <- as.numeric(eps)
 
   on.exit(.Call(R_igraph_finalizer))
   # Function call
@@ -13802,7 +13806,7 @@ strerror_impl <- function(
   igraph_errno
 ) {
   # Argument checks
-
+  igraph_errno <- as.numeric(igraph_errno)
 
   on.exit(.Call(R_igraph_finalizer))
   # Function call

src/rinterface.c

@@ -17441,7 +17441,12 @@ SEXP R_igraph_almost_equals(SEXP a, SEXP b, SEXP eps) {
   igraph_bool_t c_result;
   SEXP r_result;
                                         /* Convert input */
-
+  IGRAPH_R_CHECK_REAL(a);
+  c_a = REAL(a)[0];
+  IGRAPH_R_CHECK_REAL(b);
+  c_b = REAL(b)[0];
+  IGRAPH_R_CHECK_REAL(eps);
+  c_eps = REAL(eps)[0];
                                         /* Call igraph */
   c_result=igraph_almost_equals(c_a, c_b, c_eps);
 
@@ -17465,7 +17470,12 @@ SEXP R_igraph_cmp_epsilon(SEXP a, SEXP b, SEXP eps) {
   int c_result;
   SEXP r_result;
                                         /* Convert input */
-
+  IGRAPH_R_CHECK_REAL(a);
+  c_a = REAL(a)[0];
+  IGRAPH_R_CHECK_REAL(b);
+  c_b = REAL(b)[0];
+  IGRAPH_R_CHECK_REAL(eps);
+  c_eps = REAL(eps)[0];
                                         /* Call igraph */
   c_result=igraph_cmp_epsilon(c_a, c_b, c_eps);
 
@@ -18526,7 +18536,8 @@ SEXP R_igraph_strerror(SEXP igraph_errno) {
   const char* c_result;
   SEXP r_result;
                                         /* Convert input */
-
+  IGRAPH_R_CHECK_INT(igraph_errno);
+  c_igraph_errno = (igraph_error_t) REAL(igraph_errno)[0];
                                         /* Call igraph */
   c_result=igraph_strerror(c_igraph_errno);
 

tools/stimulus/types-RC.yaml

@@ -107,6 +107,38 @@ REAL:
             PROTECT(%I%=NEW_NUMERIC(1));
             REAL(%I%)[0]=%C%;
 
+DOUBLE:
+    # A C double - similar to REAL but uses C's double type instead of igraph_real_t
+    CTYPE: double
+    CALL:
+        IN: '%C%'
+        OUT: '&%C%'
+        INOUT: '&%C%'
+    INCONV:
+        IN: |-
+            IGRAPH_R_CHECK_REAL(%I%);
+            %C% = REAL(%I%)[0];
+    OUTCONV:
+        OUT: |-
+            PROTECT(%I%=NEW_NUMERIC(1));
+            REAL(%I%)[0]=%C%;
+
+ERROR:
+    # An igraph error code
+    # Note: No OUTCONV is provided because ERROR is handled specially as a return
+    # type - it's wrapped in IGRAPH_R_CHECK() which doesn't use output conversion.
+    # When ERROR is used as an input parameter (e.g., in igraph_strerror), only
+    # INCONV is needed.
+    CTYPE: igraph_error_t
+    CALL:
+        IN: '%C%'
+        OUT: '&%C%'
+        INOUT: '&%C%'
+    INCONV:
+        IN: |-
+            IGRAPH_R_CHECK_INT(%I%);
+            %C% = (igraph_error_t) REAL(%I%)[0];
+
 BOOLEAN:
     CTYPE: igraph_bool_t
     CALL:

tools/stimulus/types-RR.yaml

@@ -25,6 +25,16 @@ REAL:
     INCONV:
         IN: '%I% <- as.numeric(%I%)'
 
+DOUBLE:
+    # A C double - similar to REAL but uses C's double type instead of igraph_real_t
+    INCONV:
+        IN: '%I% <- as.numeric(%I%)'
+
+ERROR:
+    # An igraph error code - used as input parameter (e.g., in igraph_strerror)
+    INCONV:
+        IN: '%I% <- as.numeric(%I%)'
+
 BOOLEAN:
     DEFAULT:
         'False': 'FALSE'