-
Notifications
You must be signed in to change notification settings - Fork 166
Confirm support for Python 3.14 and drop 3.9 #985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Please upload reports for the commit 5bd58c3 to get more accurate results. Additional details and impacted files@@ Coverage Diff @@
## main #985 +/- ##
=====================================
Coverage 96.4% 96.5%
=====================================
Files 60 60
Lines 5138 5155 +17
=====================================
+ Hits 4957 4975 +18
+ Misses 181 180 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these cleanups! I think the test failures are flaky, but I've triggered a rerun to be sure. Since all tests are passing here, I think this PR includes the fixes for our nightly CI failures, so it would be great to merge this today :)
I also ran into this in khaeru/genno#179; will cherry-pick and use the same workaround here. |
|
With that change, the checks all pass (although slowly 🥲). I'll now rebase to drop the TEMPORARY commit, and then merge. |
- Update version classifiers. - Bump requires-python to 3.10.
- Add Python 3.14; use for single-version jobs. - Drop Python 3.9. Drop use of macos-13 for Python 3.9.
- Drop import & use of typing.{Optional,Union}.
- Add mark 'ixmp4_209' used/handled in iiasa/ixmp#602.
Avoid TCL errors possibly due to python/cpython#125235 and/or astral-sh/uv#7036.
Python 3.14 was released 2024-10-07. This PR is to:
ixmp4_209and handling used in Confirm support for Python 3.14 and drop 3.9 ixmp#602 are used to mark these as XFAIL.ruff check --select F401,UP007,UP045 --fixor similar multiple times, plus some small manual clean-ups. See the ruff docs.match/caseinstead of someifstatements with multipleelifblocks.Analogous to #881.
How to review
PR checklist
Add, expand, or update documentation.After approval, before merge: