Fixed the delete bug #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shibo911 LGTM!! Good Work n Thanks for contributing. |
|
@shibo911 From nxt time make sure ur only updating the files related for this issue as I see u have updated the Readme.md file too whuich is not related to this issue. Happy Contributing !!😄 |
sorry my bad, i did some mistake in git branching which caused this. again apologies and thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIXES #3
to-do-list.-.Google.Chrome.2024-03-16.12-20-27.mp4
in the App.js file, the onDelete function was already defined which was passed as a prop to the TodoList component but the TodoList component was not taking that prop. then we used the same onDelete prop in Todo component to call the function. attached the screen recording to showcase the working of the delete button.