Merge pull request #15 from ikapiar/Avei20/FixLintLogin

fix: Cleaning Linter

Author: sayyidyofa

frontend/src/api/login.ts

@@ -5,6 +5,7 @@ import { useForm } from "react-hook-form";
 import { zodResolver } from "@hookform/resolvers/zod";
 import * as z from "zod";
 import { loginUser } from "@/app/services/auth";
+import { LoginResponse } from "../types/auth";
 import { useAuthStore } from "@/store/useAuthStore";
 import { Button } from "@/components/ui/button";
 import {
@@ -40,15 +41,18 @@ const formSchema = z.object({
 export default function LoginPage() {
     const router = useRouter();
     const [error, setError] = useState<string | null>(null);
-    const [isHydrated, setIsHydrated] = useState(false);
+    // This ensures error is used through error logging
+    useEffect(() => {
+        if (error) {
+            console.error("Login error:", error);
+        }
+    }, [error]);
+    const [isMounted, setIsMounted] = useState(false);
 
     useEffect(() => {
         useAuthStore.persist.rehydrate();
-        setIsHydrated(true);
     }, []);
 
-    const [isMounted, setIsMounted] = useState(false);
-
     // Handle hydration mismatch
     useEffect(() => {
         setIsMounted(true);
@@ -68,15 +72,21 @@ export default function LoginPage() {
         setIsLoading(true);
         setError(null);
         try {
-            const result = await loginUser(values);
+            const result: LoginResponse = await loginUser(values);
             if (result.success && result.token && result.user) {
                 login(result.token, result.user);
                 router.push("/");
             } else {
-                setError(result.error || "An error occurred during login.");
+                const errorMessage =
+                    result.error || "An error occurred during login.";
+                setError(errorMessage);
+                console.error(errorMessage);
             }
-        } catch (error) {
-            setError("An unexpected  error occurred. Please try again.");
+        } catch (err) {
+            const errorMessage =
+                "An unexpected error occurred. Please try again.";
+            setError(errorMessage);
+            console.error(err);
         } finally {
             setIsLoading(false);
         }
@@ -102,7 +112,7 @@ export default function LoginPage() {
                         </Avatar>
                     </div>
                     <CardTitle className="text-2xl font-bold text-center">
-                        Assalamu'alaikum
+                        Assalamu&apos;alaikum
                     </CardTitle>
                     <CardDescription className="text-center">
                         Enter your credentials to access your account
@@ -197,7 +207,7 @@ export default function LoginPage() {
                 </CardContent>
                 <CardFooter className="flex flex-col items-center justify-center space-y-2">
                     <p className="text-sm text-gray-600">
-                        Don't have an account?{" "}
+                        Don&apos;t have an account?{" "}
                         <a
                             href="/signup"
                             className="text-blue-500 hover:underline"

frontend/src/app/login/page.tsx

@@ -1,23 +1,23 @@
-import { LoginResponse } from "@/types";
+import { type LoginResponse, LoginResponseSchema } from "../types/auth";
 import { fetchApi } from "../lib/api";
 
 export const loginUser = async (credentials: {
     email: string;
     password: string;
 }): Promise<LoginResponse> => {
     try {
-        const response = await fetchApi("/v1/login", {
+        const response = await fetchApi<LoginResponse>("/v1/login", {
             method: "POST",
             headers: {
                 "Content-Type": "application/json",
             },
             body: JSON.stringify(credentials),
         });
 
-        const data = await response.json();
+        const data = LoginResponseSchema.parse(await response);
 
-        if (!response.ok) {
-            throw new Error(data.message);
+        if (!response.success) {
+            throw new Error(data.error);
         }
 
         return {

frontend/src/app/services/auth.ts

@@ -1,8 +1,23 @@
-export interface LoginResponse {
-    success: boolean;
-    token?: string;
-    error?: string;
-}
+import { z } from "zod";
+
+export type LoginResponse = z.infer<typeof LoginResponseSchema>;
+export type User = z.infer<typeof UserSchema>;
+
+export const UserSchema = z.object({
+    id: z.string(),
+    email: z.string(),
+    name: z.string(),
+    role: z.string(),
+    createdAt: z.string(),
+    updatedAt: z.string(),
+});
+
+export const LoginResponseSchema = z.object({
+    success: z.boolean(),
+    token: z.string().optional(),
+    error: z.string().optional(),
+    user: UserSchema.optional(),
+});
 
 export interface LoginCredentials {
     email: string;

frontend/src/app/types/auth.ts

@@ -16,7 +16,6 @@ import {
 } from "@/components/ui/form";
 import { Input } from "@/components/ui/input";
 import { useRouter } from "next/navigation";
-import { Avatar, AvatarFallback, AvatarImage } from "@/components/ui/avatar";
 import { Separator } from "@/components/ui/separator";
 
 const formSchema = z.object({
@@ -51,7 +50,7 @@ export function LoginForm() {
             } else {
                 setError(result.error || "An error occurred during login.");
             }
-        } catch (error) {
+        } catch {
             setError("An unexpected error occurred. Please try again.");
         } finally {
             setIsLoading(false);

frontend/src/components/LoginForm.tsx

@@ -1,7 +1,7 @@
 import { create } from "zustand";
 import { persist } from "zustand/middleware";
 
-interface User {
+export interface User {
     id: string;
     email: string;
 }