Using cobra and viper now

Author: ilikeorangutans

action_handler.go

@@ -203,7 +203,7 @@ func (c *Client) Running() ([]FlowExecution, error) {
 
 	// Azkaban serves the login page simply with a HTTP 200 so the only way to check if we're looking at the login page
 	// is by looking for the login element.
-	if findElementWithID(doc,"username") != nil && findElementWithID(doc, "password") != nil {
+	if findElementWithID(doc, "username") != nil && findElementWithID(doc, "password") != nil {
 		return nil, errors.New("credentials expired, reauthenticate")
 	}
 

azkaban/client.go

@@ -1,148 +1,118 @@
-package main
+package cli
 
 import (
 	"bufio"
 	"bytes"
-	"errors"
 	"fmt"
 	"github.com/dustin/go-humanize"
 	"github.com/ilikeorangutans/harbormaster/azkaban"
-	"github.com/urfave/cli"
+	"github.com/spf13/cobra"
 	"log"
 	"os"
 	"strings"
 )
 
-func SetupCheckFlowAction() cli.Command {
-	handler := &CheckFlowHandler{}
-	return cli.Command{
-		Name:    "check",
+func NewCheckFlowCmd(context Context) *cobra.Command {
+	checkCmd := &cobra.Command{
+		Use:     "check",
 		Aliases: []string{"c"},
-		Usage:   "check thinks on Azkaban",
-		Subcommands: []cli.Command{
-			{
-				Name:      "flow",
-				Aliases:   []string{"f"},
-				Usage:     "check a flow",
-				ArgsUsage: "flowID",
-				Flags: []cli.Flag{
-					cli.IntFlag{
-						Name:  "n",
-						Usage: "number of executions to include in the details",
-						Value: 5,
-					},
-				},
-				Action: handler.CheckFlow,
-			},
-		},
+		Short:   "checks things",
 	}
-}
-
-type CheckFlowHandler struct {
-	ActionWithContext
-}
 
-func (h *CheckFlowHandler) CheckFlow(c *cli.Context) error {
-	if !c.Args().Present() {
-		return errors.New("expected flowID")
-	}
-
-	flowRepo := h.Context().Flows()
-	flow, proj, err := flowRepo.Flow(azkaban.Project{Name: c.GlobalString("project")}, c.Args().First())
-	if err != nil {
-		return err
-	}
-
-	statusChecker := FlowStatusChecker{
-		client:         h.Client(),
-		context:        h.Context(),
-		histogramCount: uint(c.Int("n")),
-		project:        proj,
-		flow:           flow,
-	}
+	checkFlowCmd := &cobra.Command{
+		Use:     "flow",
+		Aliases: []string{"f"},
+		Short:   "check a given flow",
+		Args:    cobra.ExactArgs(1),
+		Run: func(cmd *cobra.Command, args []string) {
+			flowRepo := context.Context().Flows()
+			flow, proj, err := flowRepo.Flow(azkaban.Project{Name: context.Project()}, args[0])
+			if err != nil {
+				log.Fatal(err)
+			}
+			statusChecker := FlowStatusChecker{
+				client:         context.Client(),
+				context:        context.Context(),
+				histogramCount: 6,
+				project:        proj,
+				flow:           flow,
+			}
 
-	status, err := statusChecker.printFlowStatus()
-	if err != nil {
-		return err
-	}
+			status, err := statusChecker.printFlowStatus()
+			if err != nil {
+				log.Fatal(err)
+			}
 
-	if status.Health == azkaban.Critical {
-		fmt.Printf("Execution failed in %q, log messages of interest:\n", status.FailedJob.ID)
-		client := h.client
-		buffer := bytes.NewBuffer([]byte{})
-		_, err := client.FetchLogsUntilEnd(status.LastExecution.ID, status.FailedJob.ID, 0, buffer)
-		if err != nil {
-			return err
-		}
+			if status.Health == azkaban.Critical {
+				fmt.Printf("Execution failed in %q, log messages of interest:\n", status.FailedJob.ID)
+				client := context.Client()
+				buffer := bytes.NewBuffer([]byte{})
+				_, err := client.FetchLogsUntilEnd(status.LastExecution.ID, status.FailedJob.ID, 0, buffer)
+				if err != nil {
+					log.Fatal(err)
+				}
 
-		scanner := bufio.NewScanner(strings.NewReader(buffer.String()))
+				scanner := bufio.NewScanner(strings.NewReader(buffer.String()))
 
-		patterns := []string{
-			"err",
-			"exception",
-			"failed",
-			"failure",
-		}
-		fmt.Println(strings.Repeat("-", 80))
-		for scanner.Scan() {
-			line := scanner.Text()
-			lower := strings.ToLower(line)
-			ofInterest := false
-			for _, p := range patterns {
-				if strings.Contains(lower, p) {
-					ofInterest = true
-					break
+				patterns := []string{
+					"err",
+					"exception",
+					"failed",
+					"failure",
 				}
-			}
-			if ofInterest {
-				fmt.Println(line)
-			}
-		}
-		fmt.Println(strings.Repeat("-", 80))
-		fmt.Println()
-
-		scanner = bufio.NewScanner(os.Stdin)
-		run := true
-
-		printActionTerm()
-		for run {
-			printActionTerm()
-			run = run && scanner.Scan()
-			input := strings.ToLower(strings.TrimSpace(scanner.Text()))
-
-			if input == "restart" {
-				client.RestartFlowNow(proj.Name, flow.FlowID)
-			} else if input == "logs" {
-				// TODO this might be slow:
-				// fmt.Println(l)
-				_, err = client.FetchLogsUntilEnd(status.LastExecution.ID, status.FailedJob.ID, 0, os.Stdout)
-				if err != nil {
-					return err
+				fmt.Println(strings.Repeat("-", 80))
+				for scanner.Scan() {
+					line := scanner.Text()
+					lower := strings.ToLower(line)
+					ofInterest := false
+					for _, p := range patterns {
+						if strings.Contains(lower, p) {
+							ofInterest = true
+							break
+						}
+					}
+					if ofInterest {
+						fmt.Println(line)
+					}
 				}
-			} else if input == "status" {
-				status, err = statusChecker.printFlowStatus()
-				if err != nil {
-					return err
+				fmt.Println(strings.Repeat("-", 80))
+				fmt.Println()
+
+				scanner = bufio.NewScanner(os.Stdin)
+				run := true
+
+				printActionTerm()
+				for run {
+					printActionTerm()
+					run = run && scanner.Scan()
+					input := strings.ToLower(strings.TrimSpace(scanner.Text()))
+
+					if input == "restart" {
+						client.RestartFlowNow(proj.Name, flow.FlowID)
+					} else if input == "logs" {
+						// TODO this might be slow:
+						// fmt.Println(l)
+						_, err = client.FetchLogsUntilEnd(status.LastExecution.ID, status.FailedJob.ID, 0, os.Stdout)
+						if err != nil {
+							log.Fatal(err)
+						}
+					} else if input == "status" {
+						status, err = statusChecker.printFlowStatus()
+						if err != nil {
+							log.Fatal(err)
+						}
+					} else if input == "unschedule" {
+						fmt.Println("not implemented yet")
+					} else {
+						run = false
+					}
 				}
-			} else if input == "unschedule" {
-				fmt.Println("not implemented yet")
-			} else {
-				run = false
 			}
-		}
-
+		},
 	}
+	checkCmd.AddCommand(checkFlowCmd)
 
-	return nil
-
-}
-
-type FlowStatus struct {
-	Project       azkaban.Project
-	Flow          azkaban.Flow
-	Health        azkaban.Health
-	LastExecution azkaban.Execution
-	FailedJob     azkaban.JobStatus
+	return checkCmd
 }
 
 type FlowStatusChecker struct {
@@ -227,3 +197,11 @@ func printActionTerm() {
 	fmt.Println("Actions: do nothing|status|restart|unschedule|logs")
 	fmt.Print("> ")
 }
+
+type FlowStatus struct {
+	Project       azkaban.Project
+	Flow          azkaban.Flow
+	Health        azkaban.Health
+	LastExecution azkaban.Execution
+	FailedJob     azkaban.JobStatus
+}