Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The argument is summarized in #2355 already. The details about the misfit is expanded on in #2481 (comment).
This held true for both of the removed decoder bindings. In BMP it is quite suspiciously so as that format is meant to be mmap'd—but the called utility reads every single byte regardless, wasting lots and lots of energy. We did not get complaints about such behavior but do get some for inefficient other operations. Let's face the reality that most of our users call into ImageReader and do not interact with the trait system directly—the static extension point also make it impossible to fit into as an optional path way into ImageReader since it is built around boxing and type erasing the underlying decoder early.
Closes: #2355
Restricting the viewport before a readout is one of the interactions I had in mind for the reader type in #2672. I'll come up with a defaulted method in
ImageDecoderinstead. Since the trait is misbehaved regardless that is a separate matter from removing it, to me.