-
Notifications
You must be signed in to change notification settings - Fork 515
Open
Description
Inertia adapter(s) affected
- React
- Vue 3
- Svelte
- Not Applicable
JS package version
2.0.x
Backend stack (optional)
No response
Describe the problem
Currently the form helper's onSuccess
, onError
, onCancel
, and onFinish
callbacks all set processing = false
and progress = null
. I'm sure this was done for a reason, but I'm suggesting it only be called in onFinish
.
Aside from the pedantic and DRY reasons to do this, this also helps those of us using the feature of onSuccess
and onError
where you can return a promise, and onFinish
won't be called until it resolves.
I'm using that feature in some forms that do work in a background job, which I poll the status of inside the promise, and it'd be nice if the form's processing
was true during that entire time and not just the initial submission.
Steps to reproduce
n/a
Metadata
Metadata
Assignees
Labels
No labels