fix: allow cross platform remote backups #25026
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skladd
changed the title
Closes influxdata#8256 As now, in v1.x influxd backup DBRetentionAndShardFromPath() uses the local path separator, e.g. "/" on Unix. This does not work when restoring data from systems using the other one, i.e. "\" on Windows. The proposed change tries both separators before returning an error. - [X] I've read the contributing section of the project [README](https://github.com/influxdata/influxdb/blob/main/README.md). - [X] Signed [CLA](https://influxdata.com/community/cla/) (if not already signed).
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8256
As now, in v1.x influxd backup DBRetentionAndShardFromPath() uses the local path separator, e.g. "/" on Unix. This does not work when restoring data from systems using the other one, i.e. "" on Windows. The proposed change tries both separators before returning an error.