Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface Section: Reduce verbosity when returning Boolean #55

Open
kkruups opened this issue Mar 4, 2016 · 0 comments
Open

Interface Section: Reduce verbosity when returning Boolean #55

kkruups opened this issue Mar 4, 2016 · 0 comments

Comments

@kkruups
Copy link

kkruups commented Mar 4, 2016

Hi Big Yuuta,

Kudos! Great Work!

One minor style change I would like to request in your interface section for interface method(s) which return a boolean.

You write :
`

 func (g HumanGroup) Less(i, j int) bool {
       if g[i].age < g[j].age {
           return true
        }
        return false
   }

`
But the following is more concise, cleaner and is inline with Golang Idiom:

`
func (g HumanGroup) Less(i, j int) bool {

    return g[i].age < g[j].age 

}

`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant