-
-
Notifications
You must be signed in to change notification settings - Fork 9
do not duplicate verification warning message, if it already existed in @code
#322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Merge branch 'main' of https://github.com/insightsengineering/teal.data # Conflicts: # tests/testthat/test-get_code.R
Signed-off-by: Marcin <[email protected]>
Update R/teal_data-datanames.R Signed-off-by: Marcin <[email protected]> add two tests for topological_sort
…om/insightsengineering/teal.data into topological_sort@669_insertUI@main
Co-authored-by: André Veríssimo <[email protected]> Signed-off-by: Marcin <[email protected]>
…om/insightsengineering/teal.data into topological_sort@669_insertUI@main
…in_keys as they might refer to datanames that do not exist in env
…ering/teal.data into 669_insertUI@main
@code
slot@code
Converting to draft, and making one more check |
Looks like might have been fixed by the removal of those lines |
fixed in the source of the problem |
Fixes insightsengineering/teal#1286
Previously, a verification warning was prepended to the
@code
slot each time aget_code(teal_data())
was run. And if a warning already existed in the code, then it was duplicated.The
@code
slot gets overwritten for teal apps, whenhashes
are added to the code (and sometimes libraries)and also during this operation the warning is added to the
@code
and then on anotherget_code()
you see the warning appearing twiceSo this PR prevents that and do not add warning again if it was already in the
@code
Tests