Skip to content

Bumps {rmarkdown} minimal version #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 11, 2024
Merged

Conversation

averissimo
Copy link
Contributor

Pull Request

Part of https://github.com/insightsengineering/coredev-tasks/issues/546

Necessary bump to overcome a lack of binary on ppm snapshots that causes an error on minimum strategies for scheduled workflows.

Copy link
Contributor

github-actions bot commented May 16, 2024

CLA Assistant Lite bot ✅ All contributors have signed the CLA

@averissimo
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@averissimo averissimo marked this pull request as ready for review May 22, 2024 22:17
Copy link
Contributor

github-actions bot commented May 22, 2024

badge

Code Coverage Summary

Filename                  Stmts    Miss  Cover    Missing
----------------------  -------  ------  -------  -----------------------------------------------------------------------------------------------------
R/AddCardModule.R           146       2  98.63%   170, 207
R/ContentBlock.R             18       2  88.89%   57-63
R/DownloadModule.R          238      67  71.85%   98-104, 152, 183-188, 197-202, 205-210, 219-224, 227-232, 240-245, 248-253, 260-265, 268-273, 312-316
R/FileBlock.R                13       0  100.00%
R/LoadReporterModule.R      103      19  81.55%   100-105, 108-113, 119-124, 136
R/NewpageBlock.R              2       0  100.00%
R/PictureBlock.R             30       2  93.33%   20, 118
R/Previewer.R               372      95  74.46%   96-98, 101-102, 184-213, 217-219, 222, 289, 304, 306-309, 312, 315-323, 437-481
R/RcodeBlock.R               15       0  100.00%
R/Renderer.R                113      37  67.26%   97-112, 216, 224, 233, 235-256
R/ReportCard.R               84       3  96.43%   239, 244, 269
R/Reporter.R                107       6  94.39%   273-278
R/ResetModule.R              53       0  100.00%
R/SimpleReporter.R           32       0  100.00%
R/TableBlock.R                9       0  100.00%
R/TextBlock.R                13       0  100.00%
R/utils.R                   126      86  31.75%   7, 38-97, 99, 102-109, 137, 161-169, 206-215
R/yaml_utils.R               81       2  97.53%   78, 289
R/zzz.R                      14      10  28.57%   2-13, 19
TOTAL                      1569     331  78.90%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 2e9d524

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented May 22, 2024

Unit Tests Summary

  1 files   18 suites   33s ⏱️
189 tests 189 ✅ 0 💤 0 ❌
329 runs  329 ✅ 0 💤 0 ❌

Results for commit 2e9d524.

♻️ This comment has been updated with latest results.

@averissimo averissimo marked this pull request as draft May 23, 2024 04:14
@averissimo
Copy link
Contributor Author

{verdepcheck} strategies pass: https://github.com/insightsengineering/teal.reporter/actions/runs/9398895960/job/25885216394

Exception is max, but that is due to Suggests dependency rtables latest from Github requires a version of formatters that is not yet released.

This is ok to merge!

@averissimo averissimo marked this pull request as ready for review June 6, 2024 11:17
@averissimo averissimo enabled auto-merge (squash) June 6, 2024 11:21
Copy link
Contributor

github-actions bot commented Jun 6, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
utils 💔 $0.42$ $+3.85$ $0$ $0$ $0$ $-1$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
utils 💔 $0.14$ $+3.86$ to_flextable_supported_class_listing_df_

Results for commit 37368e8

♻️ This comment has been updated with latest results.

@averissimo averissimo disabled auto-merge June 10, 2024 13:33
@averissimo averissimo merged commit 6394a59 into main Jun 11, 2024
33 of 34 checks passed
@averissimo averissimo deleted the 546-fix-verdepcheck@main branch June 11, 2024 08:19
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants