Skip to content

Add insightsengineering/rtables.officer to Remotes #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Conversation

m7pr
Copy link
Contributor

@m7pr m7pr commented Dec 11, 2024

A solution for

Overview

GRAN dev environment is failing http://cedar.gene.com/gran/dev/SinglePkgLogs/teal.reporter.log because rtables.officer is not released on GRAN. That's why, for the proper teal.reporter installation you need to specify the path on GitHub so rtables.officer gets installed from GitHub during regular package installation.

  pkg: teal.reporter ( Tue Dec 10 18:50:20 2024 ) -  	Existing temporary checkout found at this location. Updating
  pkg: teal.reporter ( Tue Dec 10 18:50:23 2024 ) -  	Temporary source directory successfully created: TRUE
  pkg: teal.reporter ( Tue Dec 10 18:58:44 2024 ) -  	Existing temporary checkout found at this location. Updating
  pkg: teal.reporter ( Tue Dec 10 18:58:45 2024 ) -  	Temporary source directory successfully created: TRUE
  pkg: teal.reporter ( Tue Dec 10 19:02:42 2024 ) -  	Package up to date at version 0.3.1.9018. Not rebuilding.
  ERROR  pkg: teal.reporter ( Tue Dec 10 19:20:15 2024 ) -  	Installation of teal.reporter from temporary repository failed
  ERROR  pkg: teal.reporter ( Tue Dec 10 19:20:15 2024 ) -  	Installation output:
		ERROR: dependencyrtables.officeris not available for packageteal.reporter* removing/mnt/gran_dir/GRANbuilds/dev/temp_lib/teal.reporter

That's why we added Remotes: insightsengineering/rtables.officer in DESCRIPTION file.

This issue also propagates to teal that can not be installed on GRAN dev neither http://cedar.gene.com/gran/dev/SinglePkgLogs/teal.log

  pkg: teal ( Wed Nov 20 02:49:43 2024 ) -  	Successfully checked out package source from https://gran:gldt-fDqzvirg_v-ivah2w4W-@code.roche.com/nest/insights-engineering/teal.git on branch main
  pkg: teal ( Wed Nov 20 02:49:43 2024 ) -  	Temporary source directory successfully created: TRUE
  pkg: teal ( Wed Nov 20 02:49:44 2024 ) -  	Had version 0.15.2.9088. Building new version 0.15.2.9089
  pkg: teal ( Wed Nov 20 02:49:45 2024 ) -  	Successfully built package.
  ERROR  pkg: teal ( Wed Nov 20 02:49:59 2024 ) -  	Package teal was not successfully installed and no output is available. Likely culprit: failure during installation of one of it's dependencies?

@m7pr m7pr added the core label Dec 11, 2024
@m7pr m7pr requested a review from llrs-roche December 11, 2024 09:22
Copy link
Contributor

badge

Code Coverage Summary

Filename                  Stmts    Miss  Cover    Missing
----------------------  -------  ------  -------  -----------------------------------------------------------------------------------------------------
R/AddCardModule.R           146       2  98.63%   170, 207
R/ContentBlock.R             18       2  88.89%   57-63
R/DownloadModule.R          238      67  71.85%   98-104, 152, 183-188, 197-202, 205-210, 219-224, 227-232, 240-245, 248-253, 260-265, 268-273, 312-316
R/FileBlock.R                13       0  100.00%
R/LoadReporterModule.R      103      19  81.55%   100-105, 108-113, 119-124, 136
R/NewpageBlock.R              2       0  100.00%
R/PictureBlock.R             30       2  93.33%   20, 118
R/Previewer.R               372      95  74.46%   96-98, 101-102, 184-213, 217-219, 222, 289, 304, 306-309, 312, 315-323, 437-481
R/RcodeBlock.R               15       0  100.00%
R/Renderer.R                113      37  67.26%   97-112, 216, 224, 233, 235-256
R/ReportCard.R               84       3  96.43%   239, 244, 269
R/Reporter.R                107       6  94.39%   273-278
R/ResetModule.R              53       0  100.00%
R/SimpleReporter.R           32       0  100.00%
R/TableBlock.R                9       0  100.00%
R/TextBlock.R                13       0  100.00%
R/utils.R                   126      86  31.75%   7, 38-97, 99, 102-109, 137, 161-169, 206-215
R/yaml_utils.R               81       2  97.53%   78, 289
R/zzz.R                      14      10  28.57%   2-13, 19
TOTAL                      1569     331  78.90%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 96d04a5

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Dec 11, 2024

Unit Tests Summary

  1 files   18 suites   27s ⏱️
189 tests 189 ✅ 0 💤 0 ❌
329 runs  329 ✅ 0 💤 0 ❌

Results for commit 96d04a5.

♻️ This comment has been updated with latest results.

@m7pr m7pr enabled auto-merge (squash) December 11, 2024 09:26
@m7pr m7pr merged commit 031cfdb into main Dec 11, 2024
28 checks passed
@m7pr m7pr deleted the fix_gran_builds@main branch December 11, 2024 09:27
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants