Skip to content

Commit 56b2155

Browse files
committed
amend merge criteria
the rule that the Oversight Committee needs to merge every dev-doc PR has not scaled with the project. We now write dev-docs for most design changes for any instructlab repo. This rule has also not regularly been followed. Amend this rule such that 2 maintainers of any instructlab can approve a PR and a third maintainer of any instructlab repo can verify that sufficient reviews have been given and merge a PR Signed-off-by: Charlie Doern <[email protected]>
1 parent e12aeea commit 56b2155

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

README.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,11 @@ please ping the Oversight Committee for help.
2424
out from maintainers of relevant components. The broader the scope or more
2525
controversial the change, the more broad the consensus should be required for
2626
merging. The final approval and merge (or action, e.g. deleting a repo)
27-
falls to a member of the Oversight Committee. This final review is to ensure that
27+
falls to two maintainers of any InstructLab Organization repository as well as
28+
an additional third maintainer of any InstructLab Organization repository to
29+
merge the PR after verifying that sufficient reviews have been given. If there are
30+
disputes on the design document that cannot be resolved, an Oversight Committee
31+
member can be consulted as an arbitrator. These approvals ensure that
2832
adequate opportunity and attention has been given by the affected parties.
2933
* Examples of non-trivial changes include approving proposal for new repositories,
3034
creation of new repositories, changes to organization level GitHub settings, archiving

0 commit comments

Comments
 (0)