Skip to content

Modularization? #3

Open
Open
@mmalecki

Description

@mmalecki

Hello,

Firstly, thanks for this module. It indeed reduced time to market (time I spent swearing) and enabled stakeholders (me) to focus on developing business synergy (finding cool people to follow).

Secondly, the name of the game when it comes to sharing Terraform code appears to be modules. These assume no external dependencies, like terraform_remote_state, etc. I've modularized these workspaces to make them work with my IaC automation (Terragrunt), so instead of changing terraform.tfvars, my invocation and configuration looks sort of like this:

module "mastodon" {
  source = "./../../modules/mastodon-gcp/mastodon"

  project = data.terraform_remote_state.org_structure.outputs.service_project_ids.social

  create_admin = false

  local_domain = "mmalecki.com"
  web_domain   = var.mastodon_domain_name

  smtp_from_address        = "mastodon@${var.mastodon_domain_name}"
  smtp_domain              = var.mastodon_domain_name
  # ...etc, etc.
}

My question is, would you be open to accepting a PR to make this codebase work like this, or do you like it the way it is :) ?

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requesthelp wantedExtra attention is needed

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions