-
Notifications
You must be signed in to change notification settings - Fork 95
Description
The Authorization Server should support subject
fields in the grant request. It should be similar to the accesses
in that a separate table manages each grant's subject
fields.
- Add
subjects
table to AS database- Has many-to-one relation with grants table
- Columns should include
sub_id
andsub_id_format
(each subject item in the request would create a separate row in the subjects)
To pick up a draggable item, press the space bar. While dragging, use the arrow keys to move the item. Press space again to drop the item in its new position, or press escape to cancel.Add logic in grant request endpoint to create associatedsubjects
rowsAdd logic in token introspection route handler to return thesubjects
access control for the associated grant in the response.Addsubjects
field in/grant/{id}/{nonce}
response- Add
subjects
to OpenAPI spec for IDP
To pick up a draggable item, press the space bar. While dragging, use the arrow keys to move the item. Press space again to drop the item in its new position, or press escape to cancel.To pick up a draggable item, press the space bar. While dragging, use the arrow keys to move the item. Press space again to drop the item in its new position, or press escape to cancel.
Prerequisites:
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Status
Todo
Milestone
Relationships
Development
Select code repository
Activity
mkurapov commentedon Mar 14, 2025
Should we store each subject item (sub_id sub_id_format) in a separate row? (ie to not store a list as a column)
njlie commentedon Mar 14, 2025
I'm cool with that - I originally envisioned this as being parallel to how an
access
row has a column for all the accesses for a given grant, but with subject ids I can see separate rows making sense as they're not as interchangeable as access actions.njlie commentedon May 27, 2025
@mkurapov So in responding to @cozminu's questions about the
subject
field in the Grant Continuation response, I notice thatsubject
is not a field that is supported in the token introspection response (see https://datatracker.ietf.org/doc/html/rfc9767#section-5.5.2).As I understand it, the
subject
field's value is during the interaction, where the IDP acquires the requested subject information in the/grant/{id}/{nonce}
response and verifies that the resource owner performing the interaction owns the wallet address in the requested subject information field. So it's not necessary forsubject
to be returned in the introspection response.If we insist on returning the requested
subject
in the token introspection response, it would have to be part of an opinionated stance on GNAP. Thoughts on keepingsubject
in the token introspection response? Personally I think we don't need to - the veracity of thesubject
field should be communicated to the client at the time of interaction completion.mkurapov commentedon May 27, 2025
Agreed @njlie. If the RS does not need the
subject
field (especially since it is not included in the GNAP token introspection response), we shouldn't include it in the response.cozminu commentedon May 28, 2025
ok, so from my understanding the item: `Add logic in token introspection route handler to return the
subjects
access control for the associated grant in the response.` is not relevantmkurapov commentedon May 28, 2025
@cozminu that's correct