/search/inside incorrectly including aggregates/facets

[cdrini]

Problem

Our search inside endpoint is including aggregates in the response: https://openlibrary.org/search/inside.json?q=gandalf

These should be excluded by the nofacets: true call here:

openlibrary/openlibrary/core/fulltext.py

Line 52 in 73812d5

**({'nofacets': 'true'} if not facets else {}),

But it seems like the API has changed. Facets are expensive and we shouldn't request them if we're not using them, so let's see how we can remove them.

Reproducing the bug

1. Go to https://openlibrary.org/search/inside.json?q=gandalf

• Expected behavior: No aggregates in response
• Actual behavior: Aggregates in response

Context

• Browser (Chrome, Safari, Firefox, etc): FF
• OS (Windows, Mac, etc): Win11
• Logged in (Y/N): Y
• Environment (prod, dev, local): prod

Breakdown

Requirements Checklist

• [ ]

Related files

• openlibrary/openlibrary/core/fulltext.py

  Line 52 in 73812d5

  **({'nofacets': 'true'} if not facets else {}),

Stakeholders

---

Instructions for Contributors

• Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.

[cdrini]

Ah never mind, non-issue! This appears by design, the JSON endpoint includes the facets, the HTML one does not, so this is working correctly