Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store cholesky factors rather than recompute them in Woodbury #3

Open
oxinabox opened this issue Nov 16, 2020 · 0 comments
Open

Store cholesky factors rather than recompute them in Woodbury #3

oxinabox opened this issue Nov 16, 2020 · 0 comments

Comments

@oxinabox
Copy link
Member

Follow up to #2

we should probably store
C_S = cholesky(W.S)

C_B for

B = C_S.U' \ (W.A * cholesky(W.D).U')
C_B = cholesky(Symmetric(I + B'B))

as well as the original matrix.
As these tend to be needed for many operations, and don't need to be recomputed as long as the matrix isn't changed.

One question is making sure this works OK with AD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant